723153 - Remove old safebrowsing store from profiles

Status: REOPENED

(Toolkit :: Safe Browsing, defect, P5)

Description

[Gian-Carlo Pascutto [:gcp]]

Bug 673470 introduces the new safebrowsing store. We should remove the old store when users aren't expected to switch to a Firefox version using the old one any more. Bug 673470 landed in Firefox 13, so this would be for when that is released, namely Firefox 16.

Comment 1

[Manoj]

(In reply to Gian-Carlo Pascutto (:gcp) from comment #0)
> Bug 673470 introduces the new safebrowsing store. We should remove the old
> store when users aren't expected to switch to a Firefox version using the
> old one any more. Bug 673470 landed in Firefox 13, so this would be for when
> that is released, namely Firefox 16.

Why not land this cleanup code in Firefox 13? This way, it can bake in the nightlies and in Aurora.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Because Firefox 13 is in the Nightlies. If users switch between Nightly and Aurora, they will be a) without protection b) downloading the complete database on every browser start.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Bug 673470 landed in Nightlies for Firefox 17, so scheduling this for Firefox 19 or 20.

Comment 5

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 6

[Manish [:manishkk]]

:gcp

May I know the status of old safebrowsing store?

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Should be safe to delete for about 7 years :-)

Comment 8

[Gian-Carlo Pascutto [:gcp]]

Basically the file urlclassifier3.sqlite can be deleted from the profile.

Comment 9

[Manish [:manishkk]]

:gcp

the file doesn't exist but the usage of 'urlclassifier3.sqlite' exist
https://searchfox.org/mozilla-central/search?q=urlclassifier3.sqlite&case=false&regexp=false&path=

Comment 10

[Gian-Carlo Pascutto [:gcp]]

As explained in the comments above, Firefox 17 and later will no longer create or use the file. The point of this bug is to clean it up if it exists, i.e. if the users profile dates from before those versions.

It looks like this code which you found can also be removed as part of the cleanup:
https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/core/Telemetry.cpp#1425

And from investigating my profile, the file "urlclassifierkey3.txt" could also be deleted if present. I think that dates from before the time we used HTTPS for SafeBrowsing. That was changed in bug 783047.

Comment 11

[Manish [:manishkk]]

Attachment: Bug 723153- Remove old safebrowsing store from profiles

Comment 12

[Manish [:manishkk]]

Seems file "urlclassifierkey3.txt" doesn't exist anymore!

Comment 13

[Gian-Carlo Pascutto [:gcp]]

Seems file "urlclassifierkey3.txt" doesn't exist anymore!

Please see comment 10. This will be present in profiles predating Firefox 29 (bug 783047).

Comment 14

[Manish [:manishkk]]

Please check comment on the patch in phab!

Comment 15

[Gian-Carlo Pascutto [:gcp]]

I don't see any comments in phabricator?

Comment 16

[Manish [:manishkk]]

this line should exist?
https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/tests/unit/head_urlclassifier.js#44

Comment 17

[Gian-Carlo Pascutto [:gcp]]

It can be removed. It's part of the tests, which will create fresh, new profiles, and current Firefox versions won't create the file any more so it'll never be present.