723217 - White boxes instead of plugin content after tapping to play

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[:Margaret Leibovic]

I'm seeing this on: http://people.mozilla.org/~mwargers/tests/plugins/flash/flashembed.html.

I thought it was happening on all sites, but some sites partially work. On http://www.adobe.com/software/flash/about/ the top banner will play correctly, but the smaller element in the bottom right won't. Also, on http://www.dairyqueen.com, the "How do you DQ?" banner and the menu below will show up, but the content in the middle of the framed area doesn't appear.

Comment 1

[:Margaret Leibovic]

Works for me with latest m-c now.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Currently busted for me on m-c under Froyo, at least.

Comment 4

[:Margaret Leibovic]

(In reply to Margaret Leibovic [:margaret] from comment #1)
> Works for me with latest m-c now.

Ah, I'm dumb and installed the wrong APK. Yeah, still busted on Gingerbread :(

Comment 5

[Martijn Wargers (dead)]

Regression from bug 90268?

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

To clarify, this is busted on all versions of Android. Not just Froyo.

Comment 7

[Josh Aas]

Attachment: fix v1.0

The first part of the fix is cutting off instantiation at a better place when the user has not clicked yet. The second part is letting stream data get delivered after instantiation. I couldn't resist cleaning up the click-to-play implementation to not pass its state variable all over the place.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 595888 [details] [diff] [review]
fix v1.0

Review of attachment 595888 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me

Comment 9

[Josh Aas]

Try run:

https://tbpl.mozilla.org/?tree=Try&rev=49e74dea72a1

Comment 10

[Josh Aas]

pushed to mozilla-inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/40c36f6068d6

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/40c36f6068d6

Comment 12

[Gabriela [:gaby2300]]

I can still see this bug in Galaxy S 2, Android 2.3.4 and build 20120315

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

There appears to be a problem with full page plugins. This bug already has a patch that was committed, though, so I've opened a new bug for this, 736998.

Comment 14

[Philip Chee]

Linkify Bug 736998