Properly premultiply during JPG encode/decode

RESOLVED FIXED in mozilla13

Status

()

Core
ImageLib
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

(Blocks: 1 bug)

unspecified
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Parent bug is Bug 713143.
(Assignee)

Comment 1

5 years ago
Created attachment 593537 [details] [diff] [review]
Premultiply JPG data correctly

Clean try run at: https://tbpl.mozilla.org/?tree=Try&rev=334cf17cf17e
Attachment #593537 - Flags: review?(joe)
Comment on attachment 593537 [details] [diff] [review]
Premultiply JPG data correctly

Review of attachment 593537 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine; I presume you decided not to use GFX_PREMULTIPLY because you're unifying all (un)premultiplication in a separate bug?
Attachment #593537 - Flags: review?(joe) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 595577 [details] [diff] [review]
Premultiply JPG data correctly

I forgot that gfxColor.h had an individual GFX_PREMULTIPLY. It's a worse approximation, but at least it's consistent. 

Changed that and pushed back to try. Carrying forward r+ unless the trypush collapses.

https://tbpl.mozilla.org/?tree=Try&rev=029660d930a6
Attachment #593537 - Attachment is obsolete: true
Attachment #595577 - Flags: review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/308b3ced990b
Target Milestone: --- → mozilla13
(Assignee)

Comment 5

5 years ago
Looks like this got skipped over:
https://hg.mozilla.org/mozilla-central/rev/308b3ced990b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.