723232 - nsHTMLEditRules::RelativeChangeIndentationOfElementNode removes divs with any one attribute

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

... unless that attribute is |style|. If you want a test, you'll have to write it yourself, I'm afraid.

Comment 1

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 593545
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/c59f7f7e668c
Try run started, revision c59f7f7e668c. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=c59f7f7e668c

Comment 2

[Mozilla RelEng Bot]

Try run for 77b6037385fe is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=77b6037385fe
Results (out of 14 total builds):
    exception: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-77b6037385fe

Comment 3

[Mozilla RelEng Bot]

Try run for 7093ca8965ac is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7093ca8965ac
Results (out of 14 total builds):
    exception: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7093ca8965ac

Comment 4

[Mozilla RelEng Bot]

Try run for c59f7f7e668c is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c59f7f7e668c
Results (out of 206 total builds):
    exception: 2
    success: 169
    warnings: 35
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-c59f7f7e668c

Comment 5

[(no longer active)]

Comment on attachment 593545 [details] [diff] [review]
Patch v1

See the failures here: https://tbpl.mozilla.org/php/getParsedLog.php?id=9015625&tree=Try#error0

This tells me that the div in this test has a single attribute which is not a style attribute.  Can you please print it out to see what it is?  The thing that the test is testing for is the desired behavior, but I'm curious to know why it breaks with this patch.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Ah, interesting. It's _moz_dirty. Now to figure out why my cleanup fixes it...

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Alright, that's because I suck at boolean logic.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

Comment 9

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 594423
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/2a10ad08202c
Try run started, revision 2a10ad08202c. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=2a10ad08202c

Comment 10

[Mozilla RelEng Bot]

Try run for 2a10ad08202c is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=2a10ad08202c
Results (out of 14 total builds):
    exception: 12
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-2a10ad08202c

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/7c974542dc5f