nsHTMLEditRules::RelativeChangeIndentationOfElementNode removes divs with any one attribute

RESOLVED FIXED in mozilla13

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 593545 [details] [diff] [review]
Patch v1

... unless that attribute is |style|. If you want a test, you'll have to write it yourself, I'm afraid.
Attachment #593545 - Flags: review?(ehsan)

Updated

5 years ago
Whiteboard: [autoland-try] → [autoland-in-queue]

Comment 1

5 years ago
Autoland Patchset:
	Patches: 593545
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/c59f7f7e668c
Try run started, revision c59f7f7e668c. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=c59f7f7e668c

Comment 2

5 years ago
Try run for 77b6037385fe is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=77b6037385fe
Results (out of 14 total builds):
    exception: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-77b6037385fe

Comment 3

5 years ago
Try run for 7093ca8965ac is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7093ca8965ac
Results (out of 14 total builds):
    exception: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-7093ca8965ac

Comment 4

5 years ago
Try run for c59f7f7e668c is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c59f7f7e668c
Results (out of 206 total builds):
    exception: 2
    success: 169
    warnings: 35
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-c59f7f7e668c

Updated

5 years ago
Whiteboard: [autoland-in-queue]
Comment on attachment 593545 [details] [diff] [review]
Patch v1

See the failures here: https://tbpl.mozilla.org/php/getParsedLog.php?id=9015625&tree=Try#error0

This tells me that the div in this test has a single attribute which is not a style attribute.  Can you please print it out to see what it is?  The thing that the test is testing for is the desired behavior, but I'm curious to know why it breaks with this patch.
Attachment #593545 - Flags: review?(ehsan)
(Assignee)

Comment 6

5 years ago
Ah, interesting. It's _moz_dirty. Now to figure out why my cleanup fixes it...
(Assignee)

Comment 7

5 years ago
Alright, that's because I suck at boolean logic.
(Assignee)

Comment 8

5 years ago
Created attachment 594423 [details] [diff] [review]
Patch v2
Attachment #594423 - Flags: review?(ehsan)
(Assignee)

Updated

5 years ago
Attachment #593545 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Whiteboard: [autoland-try]

Updated

5 years ago
Whiteboard: [autoland-try] → [autoland-in-queue]

Comment 9

5 years ago
Autoland Patchset:
	Patches: 594423
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/2a10ad08202c
Try run started, revision 2a10ad08202c. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=2a10ad08202c

Comment 10

5 years ago
Try run for 2a10ad08202c is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=2a10ad08202c
Results (out of 14 total builds):
    exception: 12
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-2a10ad08202c

Updated

5 years ago
Whiteboard: [autoland-in-queue]
(Assignee)

Updated

5 years ago
Blocks: 724261
(Assignee)

Updated

5 years ago
Depends on: 724259
Attachment #594423 - Flags: review?(ehsan) → review+
(Assignee)

Comment 11

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7c974542dc5f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.