Closed Bug 723232 Opened 9 years ago Closed 9 years ago

nsHTMLEditRules::RelativeChangeIndentationOfElementNode removes divs with any one attribute

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
... unless that attribute is |style|. If you want a test, you'll have to write it yourself, I'm afraid.
Attachment #593545 - Flags: review?(ehsan)
Whiteboard: [autoland-try] → [autoland-in-queue]
Autoland Patchset:
	Patches: 593545
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/c59f7f7e668c
Try run started, revision c59f7f7e668c. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=c59f7f7e668c
Try run for 77b6037385fe is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=77b6037385fe
Results (out of 14 total builds):
    exception: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-77b6037385fe
Try run for 7093ca8965ac is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=7093ca8965ac
Results (out of 14 total builds):
    exception: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-7093ca8965ac
Try run for c59f7f7e668c is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c59f7f7e668c
Results (out of 206 total builds):
    exception: 2
    success: 169
    warnings: 35
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-c59f7f7e668c
Whiteboard: [autoland-in-queue]
Comment on attachment 593545 [details] [diff] [review]
Patch v1

See the failures here: https://tbpl.mozilla.org/php/getParsedLog.php?id=9015625&tree=Try#error0

This tells me that the div in this test has a single attribute which is not a style attribute.  Can you please print it out to see what it is?  The thing that the test is testing for is the desired behavior, but I'm curious to know why it breaks with this patch.
Attachment #593545 - Flags: review?(ehsan)
Ah, interesting. It's _moz_dirty. Now to figure out why my cleanup fixes it...
Alright, that's because I suck at boolean logic.
Attached patch Patch v2Splinter Review
Attachment #594423 - Flags: review?(ehsan)
Attachment #593545 - Attachment is obsolete: true
Whiteboard: [autoland-try]
Whiteboard: [autoland-try] → [autoland-in-queue]
Autoland Patchset:
	Patches: 594423
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/2a10ad08202c
Try run started, revision 2a10ad08202c. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=2a10ad08202c
Try run for 2a10ad08202c is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=2a10ad08202c
Results (out of 14 total builds):
    exception: 12
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-2a10ad08202c
Whiteboard: [autoland-in-queue]
Blocks: 724261
Depends on: 724259
Attachment #594423 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/7c974542dc5f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.