Last Comment Bug 723249 - JSString::dump, JSString::equals, JSObject::dump debug-only helpers
: JSString::dump, JSString::equals, JSObject::dump debug-only helpers
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla13
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-01 12:24 PST by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-02-02 07:16 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (8.24 KB, patch)
2012-02-01 12:24 PST, Jeff Walden [:Waldo] (remove +bmo to email)
luke: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2012-02-01 12:24:05 PST
Created attachment 593560 [details] [diff] [review]
Patch
Comment 1 Luke Wagner [:luke] 2012-02-01 13:28:53 PST
Comment on attachment 593560 [details] [diff] [review]
Patch

Review of attachment 593560 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.  I would send an email to dev-internals announcing new str->equals and x->dump powers.

::: js/src/jsfriendapi.cpp
@@ +404,5 @@
> +    atom->dump();
> +}
> +
> +extern void
> +dumpChars(const jschar *s, size_t n)

DumpChars, please
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2012-02-01 14:51:22 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/e77b4ecdd01f
Comment 4 Ed Morley [:emorley] 2012-02-02 07:16:19 PST
https://hg.mozilla.org/mozilla-central/rev/e77b4ecdd01f

Note You need to log in before you can comment on or make changes to this bug.