Closed Bug 723281 Opened 8 years ago Closed 7 years ago

Add the ability to enable/disable paint flashing as a [gcli] command

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement)

enhancement
Not set

Tracking

(firefox22 verified)

RESOLVED FIXED
Firefox 22
Tracking Status
firefox22 --- verified

People

(Reporter: jaws, Assigned: paul)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 344411 added paint flashing to Firefox, and it is a good tool for web developers to see what regions of their site require repainting while interacting with their site.

We should add a button to enable/disable paint flashing for web developers somewhere in the developer tools.

The current paint flashing is done on browser chrome as well as content. We may want to add a separate pref that only performs paint flashing on content, but paint flashing the browser chrome may not hurt either.
That doesn't look like the right bug number?
Oh sorry, it is bug 334411 that implemented paint flashing.

The preference for it is nglayout.debug.paint_flashing and set it to true. It is hidden by default.
I've tried out the paint flashing feature. It's very cool!

I think that web developers would ideally only turn it on for their webapp (in other words, just for content and just the content for the tab they're looking at). Developers could find this useful as it is, but it feels like a browser developer feature rather than a web developer one because of its global effect.

Once we have the developer toolbar, it seems like it would be easy to add a command for this.
yeah, I'm thinking a command for this, not necessarily an actual "button" in the toolbar.

cc'ing joe to mark this up for command control.
Summary: Add the ability to enable/disable paint flashing as a developer tool feature → Add the ability to enable/disable paint flashing as a [gcli] command
New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"
Component: Developer Tools → Developer Tools: Graphic Commandline and Toolbar
Depends on: 847890
Attached patch patch v0.9 (obsolete) — Splinter Review
No proper icon for now.
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #724183 - Flags: feedback?(jwalker)
Comment on attachment 724183 [details] [diff] [review]
patch v0.9

Review of attachment 724183 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/commandline/BuiltinCommands.jsm
@@ +2088,5 @@
> +    exec: function(args, context) {
> +      if (args.chrome) {
> +        var window = context.environment.chromeDocument.defaultView;
> +      } else {
> +        var window = context.environment.contentDocument.defaultView;

double var

::: browser/locales/en-US/chrome/browser/devtools/gclicommands.properties
@@ +1008,5 @@
>  scratchpadOpenTooltip=Scratchpad
> +
> +# LOCALIZATION NOTE (paintflashingDesc) A very short string used to describe the
> +# function of the "paintflashing" command
> +paintflashingDesc=Highlight painted area.

For one-line descriptions we don't end with a full-stop.
Attachment #724183 - Flags: feedback?(jwalker) → feedback+
Attached patch patch v1Splinter Review
Attachment #724183 - Attachment is obsolete: true
Attachment #724230 - Flags: review?(jwalker)
Attachment #724230 - Flags: review?(jwalker) → review+
Attached patch addendumSplinter Review
Attachment #724234 - Flags: review?(jwalker)
Attachment #724234 - Flags: review?(jwalker) → review+
https://hg.mozilla.org/mozilla-central/rev/40c15b9a5d14
https://hg.mozilla.org/mozilla-central/rev/d398e268b1db
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Backed out since bug 847890 was backed out:
https://hg.mozilla.org/mozilla-central/rev/69aaf27c6841
https://hg.mozilla.org/mozilla-central/rev/512ef393c2ce
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b0000e1b0317
https://hg.mozilla.org/mozilla-central/rev/37ea428eee3d
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
toggling nglayout.debug.paint_flashing does not work anymore on web pages. 

This option does work on Nightly's "internal" pages, like about:newtab, Library Window, About:addons etc.
never mind. Got my answer elsewhere.
Verified as fixed on Firefox 22 beta 2 - Highlight Painted Area button is added to the new developer toolbox.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20100101 Firefox/22.0
Build ID: 20130521223249
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.