Fix params in addTab on session restore failure

VERIFIED FIXED in Firefox 11

Status

()

Firefox for Android
General
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
Firefox 13
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, firefox13 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js
>       // Be ready to handle any restore failures by making sure we have a valid tab opened
>       let restoreCleanup = {
>         observe: function(aSubject, aTopic, aData) {
>           Services.obs.removeObserver(restoreCleanup, "sessionstore-windows-restored");
>           if (aData == "fail") {
>             let params = { selected: restoreToFront };
>             BrowserApp.addTab("about:home", { showProgress: false });
>           }

The params variable isn't used here (looks like I forgot to pass it to addTab in bug 592328).
(Assignee)

Comment 1

5 years ago
CC'ing margaret since she added the showProgress param.
(Assignee)

Comment 2

5 years ago
Created attachment 593655 [details] [diff] [review]
patch

Remove "params" variable and add "selected" to addTab() params.
Attachment #593655 - Flags: review?(mark.finkle)
Attachment #593655 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

5 years ago
Landed on inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/252293f10484
(Assignee)

Comment 4

5 years ago
Comment on attachment 593655 [details] [diff] [review]
patch

[Approval Request Comment]
Fixes bug where externally loaded URL may not be selected if doing a session restore. Low risk.
Attachment #593655 - Flags: approval-mozilla-beta?
Attachment #593655 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 5

5 years ago
(In reply to Brian Nicholson (:bnicholson) from comment #0)
> The params variable isn't used here (looks like I forgot to pass it to
> addTab in bug 592328).

Erm, that's bug 701092. Slightly off.

Comment 6

5 years ago
Comment on attachment 593655 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593655 - Flags: approval-mozilla-beta?
Attachment #593655 - Flags: approval-mozilla-beta+
Attachment #593655 - Flags: approval-mozilla-aurora?
Attachment #593655 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/252293f10484
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/releases/mozilla-aurora/rev/fefd5adb4134
status-firefox11: --- → affected
status-firefox12: --- → fixed
status-firefox13: --- → affected
status-firefox13: affected → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/b20fd923081b
status-firefox11: affected → fixed
Verified fixed on:

Firefox 13.0a1 (2012-02-06)
20120206031148
http://hg.mozilla.org/mozilla-central/rev/814d0b2dbaba
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 12.0a2 (2012-02-06)
20120206042011
http://hg.mozilla.org/releases/mozilla-aurora/rev/9fb0c06ceb49
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 11.0
20120206202409
http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116
Device: HTC Desire Z
OS: Android 2.3.3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.