723349 - Fix params in addTab on session restore failure

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js
>       // Be ready to handle any restore failures by making sure we have a valid tab opened
>       let restoreCleanup = {
>         observe: function(aSubject, aTopic, aData) {
>           Services.obs.removeObserver(restoreCleanup, "sessionstore-windows-restored");
>           if (aData == "fail") {
>             let params = { selected: restoreToFront };
>             BrowserApp.addTab("about:home", { showProgress: false });
>           }

The params variable isn't used here (looks like I forgot to pass it to addTab in bug 592328).

Comment 1

[Brian Nicholson (:bnicholson)]

CC'ing margaret since she added the showProgress param.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: patch

Remove "params" variable and add "selected" to addTab() params.

Comment 3

[Brian Nicholson (:bnicholson)]

Landed on inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/252293f10484

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 593655 [details] [diff] [review]
patch

[Approval Request Comment]
Fixes bug where externally loaded URL may not be selected if doing a session restore. Low risk.

Comment 5

[Brian Nicholson (:bnicholson)]

(In reply to Brian Nicholson (:bnicholson) from comment #0)
> The params variable isn't used here (looks like I forgot to pass it to
> addTab in bug 592328).

Erm, that's bug 701092. Slightly off.

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 593655 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/252293f10484

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fefd5adb4134

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b20fd923081b

Comment 10

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-02-06)
20120206031148
http://hg.mozilla.org/mozilla-central/rev/814d0b2dbaba
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 12.0a2 (2012-02-06)
20120206042011
http://hg.mozilla.org/releases/mozilla-aurora/rev/9fb0c06ceb49
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 11.0
20120206202409
http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116
Device: HTC Desire Z
OS: Android 2.3.3