723398 - update brownbag request form to remove "Confidential Mozilla Corporation Bug" group

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[:glob ✱]

It appears that bugs submitted with this form are marked "Confidential Mozilla Corporation Bug".   Can we have that box unchecked by default?

Comment 1

[:glob ✱]

richard: how do you feel about making the bug public if the "intended audience" is "public", and keeping it confidential if the "intended audience" is "employees only" or "interns" ?

Comment 2

[Richard A Milewski[:richard]]

I think keeping MoCo only bugs confidential is fine, but we've been treating intern brownbags as public, i.e. streaming live on AirMo and publicly accessible recordings in the archive.

Comment 3

[David Lawrence [:dkl]]

We could pretty easily just set the group depending on how the intended audience drop down is set. 

Employees Only  = Mozilla Corporation
Everything Else = No Groups

Does this work for you?

dkl

Comment 4

[Richard A Milewski[:richard]]

Sounds like a good solution to the problem.

Comment 5

[David Lawrence [:dkl]]

Attachment: Patch to add moco-conf group if intended audience is employees only (v1)

Comment 6

[:glob ✱]

Comment on attachment 594804 [details] [diff] [review]
Patch to add moco-conf group if intended audience is employees only (v1)

instead of adding the groups element when required, it'll be much simpler to default the hidden field to empty, and set the value when the audience is 'Employees Only'.

Comment 7

[David Lawrence [:dkl]]

(In reply to Byron Jones ‹:glob› from comment #6)
> Comment on attachment 594804 [details] [diff] [review]
> Patch to add moco-conf group if intended audience is employees only (v1)
> 
> instead of adding the groups element when required, it'll be much simpler to
> default the hidden field to empty, and set the value when the audience is
> 'Employees Only'.

I tried that first but BZ throws an error when 'groups' is defined but empty. So we cannot pass it as empty unless we want to set a group.

dkl

Comment 8

[:glob ✱]

Comment on attachment 594804 [details] [diff] [review]
Patch to add moco-conf group if intended audience is employees only (v1)

ah, because enter_bug uses checkboxes, not a hidden field.

r=glob

Comment 9

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified extensions/BMO/template/en/default/bug/create/create-brownbag.html.tmpl
Committed revision 8057.

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified extensions/BMO/template/en/default/bug/create/create-brownbag.html.tmpl
Committed revision 8044

dkl