The default bug view has changed. See this FAQ.

in function GonkCameraInputStream::Init(nsACString_internal&, nsCaptureParams*):/home/cjones/mozilla/mozilla-central/netwerk/protocol/device/GonkCaptureProvider.cpp:263: error: undefined reference to 'HAL_getNumberOfCameras'

RESOLVED FIXED in mozilla13

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cjones, Assigned: fabrice)

Tracking

Trunk
mozilla13
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(2 attachments)

This happens when I build b2g while configured for the emulator.  Apparently the emulator doesn't have a libcamera.so to link against, at least our version of it.
Created attachment 593741 [details] [diff] [review]
Don't link against HAL_getNumberOfCameras because we don't have a camera library on the emulator
Assignee: nobody → jones.chris.g
Attachment #593741 - Flags: review?(gal)

Updated

5 years ago
Attachment #593741 - Flags: review?(gal) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/558ccc18ea2c
Whiteboard: [inbound]
(Assignee)

Comment 3

5 years ago
Created attachment 593864 [details] [diff] [review]
followup

The previous patch will fail with devices that have only one camera and try to open the second one.

This patch dlsym() the HAL_getNumberOfCameras() instead.
Assignee: jones.chris.g → fabrice
Attachment #593864 - Flags: review?(jones.chris.g)
So what?
Comment on attachment 593864 [details] [diff] [review]
followup

This doesn't make sense as a member method here, imho.  I hacked because I didn't want to redactor so as to share the lib handle.  I don't trust the linker.

But let's comprise.  Make this a static method and r=me.
Attachment #593864 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 6

5 years ago
pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b71df850fb73
https://hg.mozilla.org/mozilla-central/rev/b71df850fb73
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
and the first part:
https://hg.mozilla.org/mozilla-central/rev/558ccc18ea2c
You need to log in before you can comment on or make changes to this bug.