723418 - in function GonkCameraInputStream::Init(nsACString_internal&, nsCaptureParams*):/home/cjones/mozilla/mozilla-central/netwerk/protocol/device/GonkCaptureProvider.cpp:263: error: undefined reference to 'HAL_getNumberOfCameras'

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This happens when I build b2g while configured for the emulator.  Apparently the emulator doesn't have a libcamera.so to link against, at least our version of it.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Don't link against HAL_getNumberOfCameras because we don't have a camera library on the emulator

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/558ccc18ea2c

Comment 3

[[:fabrice] Fabrice Desré]

Attachment: followup

The previous patch will fail with devices that have only one camera and try to open the second one.

This patch dlsym() the HAL_getNumberOfCameras() instead.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

So what?

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 593864 [details] [diff] [review]
followup

This doesn't make sense as a member method here, imho.  I hacked because I didn't want to redactor so as to share the lib handle.  I don't trust the linker.

But let's comprise.  Make this a static method and r=me.

Comment 6

[[:fabrice] Fabrice Desré]

pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b71df850fb73

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b71df850fb73

Comment 8

[Ed Morley [:emorley]]

and the first part:
https://hg.mozilla.org/mozilla-central/rev/558ccc18ea2c