RSS feeds are not properly recognized [rss2 feeds with isPermaLink=false and no link url only]

RESOLVED FIXED in Thunderbird 13.0

Status

MailNews Core
Feed Reader
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Matt, Assigned: alta88)

Tracking

({regression})

Thunderbird 13.0
regression

Thunderbird Tracking Flags

(thunderbird11 fixed, thunderbird12 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:10.0) Gecko/20100101 Firefox/10.0
Build ID: 20120129021758

Steps to reproduce:

I pressed "Get Messages" to update my RSS feeds. 


Actual results:

Some feeds are not updating, and one is being reported as an invalid feed in the add-on bar at the bottom of the window. I checked the web site for the problematic RSS feeds, and there are new items available. I then reverted to Thunderbird 9.0.1 and the feeds are behaving properly again.
(Reporter)

Comment 1

6 years ago
The two feeds that I know for sure had content available that wasn't being recognized are as follows:
http://podcastrss.play.it/mully-and-hanley-show_mp3_32.xml
http://podcastrss.play.it/the-mcneil-and-spiegel-show_mp3_32.xml

The feed that was being reported as invalid is https://www.audi-mediaservices.com/publish/ms/content/en/public.rss2.gid-oeffentlichkeit.xml

I am running Thunderbird in Windows 7 (32 bit), and the extensions I have installed are Add-On Compatibility Reporter, Calendar Tweaks, Folderpane Tools, Lightning, LightningButton, LookOut and NoGlass.

Comment 2

6 years ago
(In reply to Matt from comment #0)
> Some feeds are not updating, and one is being reported as an invalid feed in
> the add-on bar at the bottom of the window. I checked the web site for the
> problematic RSS feeds, and there are new items available. I then reverted to
> Thunderbird 9.0.1 and the feeds are behaving properly again.

So this issue happened just after the upgrade? Is there anything in the error console?
(Reporter)

Comment 3

6 years ago
Yes, it happened after the upgrade. After reverting to TB 9.0.1 everything worked properly again. After trying TB 10 again, even in safe mode, the problem persists. The error console is showing the following errors:

Error: Unable to report telemetry.
Source File: resource://gre/modules/PlacesDBUtils.jsm
Line: 975

www.audi-mediaservices.com : server does not support RFC 5746, see CVE-2009-3555

pop.secureserver.net : server does not support RFC 5746, see CVE-2009-3555

Error: not well-formed
Source File: https://www.audi-mediaservices.com/publish/ms/content/en/public.rss2.gid-oeffentlichkeit.xml
Line: 371, Column: 222
Source Code:
 <c:image_link_alt_00 type="string">Franziska Moennig, chair of the Presiding Committee of the „Automotive Circle International”, gave the trophy EuroCarBody Award to plant manager Albrecht Reimold  and the trophy Doors & Closures Innovation Award to Dr. Klaus Koglin, head of the technology development (to the right). Frank Martin, development door systems (to the left) and Hartmut Elsässer, project controlling A6-production, received the certifications.   </c:image_link_alt_00>

Comment 4

6 years ago
Well, giving that link to IE8 yields this error:
Whitespace is not allowed at this location.
 Line: 378 Character: 222

 <c:image_link_alt_00 type="string">Franziska Moennig, chair of the Presiding Committee of the „Automotive Circle International”, gave the trophy EuroCarBody Award to plant manager Albrecht Reimold  and the trophy Doors & Closures Innovation Award to Dr. Klaus Koglin, head of the technology development (to the right). Frank Martin, development door systems (to the left) and Hartmut Elsässer, project controlling A6-production, received the certifications.   </c:image_link_alt_00>
 
So there could be a real problem in that feed...
Is it legal to use & unescaped as &amp; entity?
Component: General → Feed Reader
Product: Thunderbird → MailNews Core
QA Contact: general → feed.reader
(Assignee)

Comment 5

6 years ago
although all 3 of these feeds (rss2) are sort of poorly constructed, only the last is cleanly handled by Tb as genuinely broken beyond salvage.

the first 2, despite failing to validate on a bad enclosure length syntax, cause Tb to choke/hang earlier for invalid reasons.  Tb attempts to create a content-base header from a null value; this should be a url.  the feeds specifically don't give a url, so Tb's assumption needs to be fixed/handled.  (the guid is a url but isPermaLink is false, and there is no link tag, so Tb assumes null).
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 6

6 years ago
After doing some more looking, the Audi RSS feed is invalid and has issues, so that one should be ignored here. I tried TB 10.0.1 and the problem still persists for the other 2 feeds. They still work perfectly well in TB 9.0.1, so something in the way TB handles RSS feeds has changed.
Component: Feed Reader → Account Manager
Product: MailNews Core → Thunderbird
(Reporter)

Updated

6 years ago
Severity: normal → critical
Component: Account Manager → Feed Reader
Product: Thunderbird → MailNews Core
(Assignee)

Comment 7

6 years ago
Created attachment 597023 [details] [diff] [review]
patch

actually, the error is on trying to set the BASE href.  this is a regression from Bug 606818, where a null went through some hoops to become a "".
Attachment #597023 - Flags: review?(mbanner)
(Assignee)

Updated

6 years ago
Keywords: regression
(Assignee)

Updated

6 years ago
Assignee: nobody → alta88
OS: Windows 7 → All
Hardware: x86 → All
Summary: RSS feeds are not properly recognized → RSS feeds are not properly recognized [rss2 feeds with isPermaLink=false and no link url only]
(Assignee)

Updated

6 years ago
Duplicate of this bug: 730137
(Assignee)

Updated

6 years ago
Attachment #597023 - Flags: approval-comm-beta?
Attachment #597023 - Flags: approval-comm-aurora?
Attachment #597023 - Flags: review?(mbanner)
Attachment #597023 - Flags: review+
Attachment #597023 - Flags: approval-comm-beta?
Attachment #597023 - Flags: approval-comm-beta+
Attachment #597023 - Flags: approval-comm-aurora?
Attachment #597023 - Flags: approval-comm-aurora+
Checked in:

http://hg.mozilla.org/comm-central/rev/7bb995ee9fa3
http://hg.mozilla.org/releases/comm-aurora/rev/79790980748a
http://hg.mozilla.org/releases/comm-beta/rev/45d5ebb045fe
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-thunderbird11: --- → fixed
status-thunderbird12: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
You need to log in before you can comment on or make changes to this bug.