Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Mark classes final or add virtual destructor in content/*

RESOLVED FIXED in mozilla13

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla13
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 593840 [details] [diff] [review]
Mark classes final or add virtual destructor in content/*

Currently builds with --enable-warnings-as-errors are broken with clang because of the warning/error

error: delete called on 'fooBar' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]

This patch fixes some of them.
Attachment #593840 - Flags: review?(jmuizelaar)
Comment on attachment 593840 [details] [diff] [review]
Mark classes final or add virtual destructor in content/*

I'm not a content peer, so I'm probably not the best reviewer for this. That being said I've submitted patches like this before and have never received any negative feedback so it's probably safe.
Attachment #593840 - Flags: review?(jmuizelaar) → review+
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f60a70c9120f

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/f60a70c9120f
Assignee: nobody → respindola
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.