723543 - Android release automation should use releaseConfig['enableMultiLocale'] instead of pf['multi_locale']

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

... to prevent changes like this:

http://hg.mozilla.org/build/buildbot-configs/rev/2145be876274

Comment 1

[Rail Aliiev [:rail]]

Hmm, here http://hg.mozilla.org/build/buildbotcustom/file/8c478665ba1d/process/release.py#l1362 we use this configuration depending on platform... Now I'm not sure if we should use this configuration value from releaseConfig.

Aki, your thoughts?

Comment 2

[Aki Sasaki (not active)]

Maybe 

multi_locale = releaseConfig.get('enableMultiLocale', False) and pf.get('multi_locale', False)

?

Comment 3

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

Comment 4

[Rail Aliiev [:rail]]

Attachment: configs

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 594241 [details] [diff] [review]
buildbotcustom

Hm, with the bool() you could just do bool(releaseConfig.get('enableMultiLocale') and pf.get('multi_locale')), but this works too.

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 594242 [details] [diff] [review]
configs

I think we're going to build android-xul with multilocale for beta2.
Android multilocale is already disabled.
I don't think this patch is needed?

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 594241 [details] [diff] [review]
buildbotcustom

http://hg.mozilla.org/build/buildbotcustom/rev/48ab730c66df

Comment 8

[Rail Aliiev [:rail]]

(In reply to Aki Sasaki [:aki] from comment #6)
> Comment on attachment 594242 [details] [diff] [review]
> configs
> 
> I think we're going to build android-xul with multilocale for beta2.
> Android multilocale is already disabled.
> I don't think this patch is needed?

Agree.