Closed Bug 723543 Opened 8 years ago Closed 8 years ago

Android release automation should use releaseConfig['enableMultiLocale'] instead of pf['multi_locale']

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

(Whiteboard: [releases][automation][mobile][simple])

Attachments

(2 files)

Hmm, here http://hg.mozilla.org/build/buildbotcustom/file/8c478665ba1d/process/release.py#l1362 we use this configuration depending on platform... Now I'm not sure if we should use this configuration value from releaseConfig.

Aki, your thoughts?
Maybe 

multi_locale = releaseConfig.get('enableMultiLocale', False) and pf.get('multi_locale', False)

?
Summary: Android release automation should use releaseConfig['multi_locale'] instead of pf['multi_locale'] → Android release automation should use releaseConfig['enableMultiLocale'] instead of pf['multi_locale']
Attached patch buildbotcustomSplinter Review
Attachment #594241 - Flags: review?(aki)
Attached patch configsSplinter Review
Attachment #594242 - Flags: review?(aki)
Comment on attachment 594241 [details] [diff] [review]
buildbotcustom

Hm, with the bool() you could just do bool(releaseConfig.get('enableMultiLocale') and pf.get('multi_locale')), but this works too.
Attachment #594241 - Flags: review?(aki) → review+
Comment on attachment 594242 [details] [diff] [review]
configs

I think we're going to build android-xul with multilocale for beta2.
Android multilocale is already disabled.
I don't think this patch is needed?
Attachment #594242 - Flags: review?(aki)
(In reply to Aki Sasaki [:aki] from comment #6)
> Comment on attachment 594242 [details] [diff] [review]
> configs
> 
> I think we're going to build android-xul with multilocale for beta2.
> Android multilocale is already disabled.
> I don't think this patch is needed?

Agree.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.