723601 - [Telemetry dashboard] Histogram selector should match inside the histogram name

Status: RESOLVED FIXED

Description

[Justin Lebar (not reading bugmail)]

I could have sworn I'd filed a bug on this, but I can't find it.  So here's a new one.

Right now, the histogram selector only matches from the beginning of the histogram name.  But I should be able to type "JPEG" into the histogram selector and see all histograms which contain "JPEG".

What I'd like is something which roughly follows the following idiom.  Here, |search| is what the user typed into the search box, and |hist| is the histogram name.  This function returns true if |hist| matches |search|.

def match(search, hist):
  search_split = set(search.toLowerCase().split()) # split on spaces
  hist_split = set(special_split(hist.toLowerCase()))

  # Return true if every element in search_split is in hist_split
  return search_split.isSubset(hist_split)

def special_split(str):
  # Split |str| on "_", but return every possible joining of tokens.  For example, 
  # special_split("foo_bar_baz") returns ["foo", "bar", "baz", "bee", "foo_bar", 
  #                                       "bar_baz", "foo_bar_baz"].
  #
  # Implementation left as an exercise to the reader.  :)

Comment 1

[Justin Lebar (not reading bugmail)]

Should be

  # special_split("foo_bar_baz") returns ["foo", "bar", "baz", "foo_bar", 
  #                                       "bar_baz", "foo_bar_baz"].

Comment 2

[Pedro Alves]

Can you write that in perl please?  ;)

Comment 3

[Justin Lebar (not reading bugmail)]

Ah!  For perl, I imagine I could get close with

  $ cat /dev/urandom | head -n10

Comment 4

[Annie Elliott]

Marking: in group of > 33 asks for Telemetry that need PM priority before triage/scheduling.

Comment 5

[Annie Elliott]

Triaged.

Comment 6

[Paulo Pires]

when searching for a measure it will not look only from the beginning of the string, but all string, for example, if you type "collector" it will show all measures that have "collector"

Comment 7

[Vladan Djeric (:vladan)]

(In reply to Paulo Pires from comment #6)
> when searching for a measure it will not look only from the beginning of the
> string, but all string, for example, if you type "collector" it will show
> all measures that have "collector"

I don't see this behavior for Histogram and Evolution views, only in the Slow SQL view. Am I misunderstadning?

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

As Justin mentioned on IRC, if you don't see this functionality you should clear your cache.

Comment 9

[Daniel Einspanjer [:dre] [:deinspanjer]]

The fix was accidentally regressed last week.  We re-opened the JIRA and are re-deploying the fix today.

Comment 10

[Paulo Pires]

This has been re-fixed.