The default bug view has changed. See this FAQ.

compile errors on Mac OS X 10.7 targeting 10.6 SDK

RESOLVED FIXED in mozilla13

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Josh Aas, Assigned: espindola)

Tracking

Trunk
mozilla13
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 593901 [details]
build log

Full log attached.

In file included from /Users/josh/src/mozilla/ff_trunk_debug_x86_64/dom/plugins/ipc/PluginUtilsOSX.mm:42:
In file included from /Users/josh/src/mozilla/ff_trunk_debug_x86_64/dom/plugins/ipc/PluginUtilsOSX.h:45:
In file included from ../../../dist/include/nsCoreAnimationSupport.h:49:
../../../dist/include/nsIOSurface.h:48:7: error: redefinition of 'NSOpenGLContext' as different kind of symbol
class NSOpenGLContext;

Comment 1

5 years ago
I'm seeing this as well. I also fingered bug 715785 as the root cause. Although, I haven't proved it.

This is the first time I haven't been able to build with the 10.7 SDK since 10.7 first came out (July 2011). Is backing out https://hg.mozilla.org/mozilla-central/rev/67b0e13d7a62 justified?
No, but we can fix this instead :)
Duplicate of this bug: 723738
I added a patch to bug 723738.
Should I just move it here?
Created attachment 593996 [details] [diff] [review]
remove forward declaration

With this forward declaration the code reduces to

@interface NSOpenGLContext {
}
@end
class NSOpenGLContext;

which gcc accepts but clang intentionally rejects.

https://tbpl.mozilla.org/?tree=Try&rev=b8b6eed5b818
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #593996 - Flags: review?(jmuizelaar)
Comment on attachment 593996 [details] [diff] [review]
remove forward declaration

I can review this. r+
Attachment #593996 - Flags: review?(jmuizelaar) → review+
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8c6eab735db2
https://hg.mozilla.org/mozilla-central/rev/8c6eab735db2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.