723635 - Remove upvotes from Answer model

Status: RESOLVED FIXED

(support.mozilla.org :: Code Quality, task)

Description

[Ricky Rosario [:rrosario, :r1cky]]

I was reading over the question extraction code and was surprised to see this column existed. Turns out it was part of the original model and it was never used or removed. We can safely remove it from the model so it avoids further confusion. Dropping the column is probably very slow and not worth it.

The indexing code should probably use `num_votes` or `num_helpful_votes`.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

We aren't using this in the index anymore.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Moving all 2012Q1 bugs to Future.

Comment 3

[Victor Neo]

I am working on this - I suppose "Dropping the column is probably very slow and not worth it." implies that I should not create a migration for this change?

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to icyisamu from comment #3)
> I am working on this - I suppose "Dropping the column is probably very slow
> and not worth it." implies that I should not create a migration for this
> change?

Exactly. I am taking a look at the pull request now. Thanks!

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Pull request is here: https://github.com/mozilla/kitsune/pull/770

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/fc7c6329e7466a2e92c00006254b822b85623d5f

Thanks Victor!

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

I landed this in prod last night.