723640 - IonMonkey: implement same RegExp native optimization as JM+TI

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Leary [:cdleary] (not checking bugmail)]

There are comments in the MRegExp as to how you can reuse the source RegExp object without cloning it in certain situations (where you understand the uses to be exactly the no-escape-permitting natives).

Comment 1

[Till Schneidereit [:till]]

Do we still need this?

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Till Schneidereit [:till] from comment #1)
> Do we still need this?

Yes, definitely! I just noticed that this should speedup some Peacekeeper jQuery tests quite a bit.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Patch

This is more or less a port of your JM no-clone implementation to Ion. This should help quite a bit on the Peacekeeper domJQueryBasicFilters test.

JM had another path to inline the object allocation in some cases, but I didn't do this yet because of RegExpShared refcounting complexity. Would it make sense to make RegExpShared a GC thing? That would make it a lot easier to inline pointers to it.

Comment 4

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e8f8322f8fd

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/5e8f8322f8fd