723671 - Status page should show DB version

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Lonnen :lonnen]

The result of `select current_version from socorro_db_version` should be shown in the status page.

Comment 1

[Lonnen :lonnen]

I think that table needs it's permissions changed so that the webapp / mware can access the info. Jberkus?

Comment 2

[Lonnen :lonnen]

realized I should have cc'd someone a while ago.

Comment 3

[Laura Thomson :laura]

This should be the hash of the most current migration.

Comment 4

[Lonnen :lonnen]

I don't think we need this anymore, and we certainly won't after we land automatic migration running [bug # needed]. Suggest wontfix.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/04a2f22e8c1b914164dd1f83e20e939ebef173b7
Fixed bug 723671 add schema revision info to middleware

https://github.com/mozilla/socorro/commit/a2a5bd6f6254a83e41ceacfee2f63462454eee2b
Merge pull request #1435 from selenamarie/bug723671-add-migration-hash-to-status

Fixed bug 723671 add schema revision info to middleware

Comment 6

[Matt Brandt [:mbrandt]]

Reopening for clarification :)

- I see comment 4 suggests wontfix; is this a willfix or should the code be backed out?
- if wontfix isn't applicable what are the minimal steps to test where is this hash present in /status/?

Comment 7

[Lonnen :lonnen]

My suggestion was not taken, but that's ok. This doesn't present any UI, so the bot was a little overzealous. The landed fix exposes the value in a new mware service.

Comment 8

[Matt Brandt [:mbrandt]]

(In reply to Chris Lonnen :lonnen from comment #7)
> My suggestion was not taken, but that's ok. This doesn't present any UI, so
> the bot was a little overzealous. The landed fix exposes the value in a new
> mware service.

Thanks :lonnen, smells [qa-].

Comment 9

[Lonnen :lonnen]

The landed patch is a partial fix because it never exposes it in the UI. We need to back it out and wontfix or expose it in /status/.

Comment 10

[Selena Deckelmann :selenamarie :selena]

Can we assign the change to status to someone that does UI work?

Comment 11

[[DEACTIVATED] Adrian Gaudebert]

I'll take that. And mind you Selena, I think I'm going to merge the service you create to the server_status service, it doesn't really make sense to have a separate service for just that value, especially since we're going to show it on the status page. :)

Comment 12

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/1453

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/4fab5fc592049d13a9372268d6f83e4495f9a323
Fixes bug 723671 - Show database version in status page, and merge the existing service with server_status. r=peterbe

Comment 14

[Lonnen :lonnen]

verified by loading https://crash-stats.allizom.org/status/, finding schema revision page.

Comment 15

[Matt Brandt [:mbrandt]]

Should the schema hash be presented as a url, much like Socorro and Breakpad revision?

Comment 16

[Robert Helmer [:rhelmer]]

(In reply to Matt Brandt [:mbrandt] from comment #15)
> Should the schema hash be presented as a url, much like Socorro and Breakpad
> revision?

I'd say no, we don't have anything useful to link to really. It's something fairly internal to Socorro, but we can use it to (automatically or manually) verify that schema updates were applied so it's nice to have on the status page.

Comment 17

[Matt Brandt [:mbrandt]]

Thanks for the knowledge transfer, I didn't realize this was an internal bit that didn't make sense (or not really able to) to linkify.