Return the profile data as JS objects

RESOLVED FIXED in mozilla13

Status

()

Core
Gecko Profiler
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla13
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
This will be nicer to use and easier to extend.
(Assignee)

Comment 1

6 years ago
Created attachment 594193 [details] [diff] [review]
Return JSObjects
Attachment #594193 - Flags: review?(bgirard)
Comment on attachment 594193 [details] [diff] [review]
Return JSObjects

Review of attachment 594193 [details] [diff] [review]:
-----------------------------------------------------------------

r+ based on us later moving JSBuilder.h

::: tools/profiler/sps/JSBuilder.h
@@ +40,5 @@
> +/* this is handy wrapper around JSAPI to make it more pleasant to use.
> + * We collect the JSAPI errors and so that callers don't need to */
> +class JSObjectBuilder
> +{
> +  public:

Typically these are left aligned.

@@ +141,5 @@
> +  JSObjectBuilder(JSContext *aCx) : mCx(aCx), mOk(JS_TRUE)
> +  {
> +  }
> +  private:
> +  JSObjectBuilder(JSObjectBuilder&);

You're not disallowing the evil assignment operator.
Attachment #594193 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/c433e993506b
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
hm, looks like this has been backed out but not annotated
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla13 → ---
https://hg.mozilla.org/mozilla-central/rev/2ee344ca2759
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.