723711 - Return the profile data as JS objects

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This will be nicer to use and easier to extend.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Return JSObjects

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 594193 [details] [diff] [review]
Return JSObjects

Review of attachment 594193 [details] [diff] [review]:
-----------------------------------------------------------------

r+ based on us later moving JSBuilder.h

::: tools/profiler/sps/JSBuilder.h
@@ +40,5 @@
> +/* this is handy wrapper around JSAPI to make it more pleasant to use.
> + * We collect the JSAPI errors and so that callers don't need to */
> +class JSObjectBuilder
> +{
> +  public:

Typically these are left aligned.

@@ +141,5 @@
> +  JSObjectBuilder(JSContext *aCx) : mCx(aCx), mOk(JS_TRUE)
> +  {
> +  }
> +  private:
> +  JSObjectBuilder(JSObjectBuilder&);

You're not disallowing the evil assignment operator.

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/c433e993506b

Comment 4

[Marco Bonardo [:mak]]

hm, looks like this has been backed out but not annotated

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/2ee344ca2759