Closed
Bug 723746
Opened 13 years ago
Closed 13 years ago
regression: XUL Fennec uses non-tablet layout on ICS tablets
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox11 fixed, firefox12 fixed, firefox13 fixed, firefox-esr1012+ verified, fennec11+)
RESOLVED
FIXED
Firefox 13
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
929 bytes,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
lsblakk
:
approval-mozilla-esr10+
|
Details | Diff | Splinter Review |
Regression from bug 671634, which changed an nsSystemInfo property from "isTablet" to "tablet" without updating the existing code that used the property.
Attachment #593993 -
Flags: review?(mark.finkle)
|
||
Updated•13 years ago
|
Attachment #593993 -
Flags: review?(mark.finkle) → review+
|
Assignee | |
Comment 1•13 years ago
|
||
Whiteboard: [has patch]
Target Milestone: --- → Firefox 13
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 593993 [details] [diff] [review]
patch
[Approval Request Comment]
Regression caused by (bug #): bug 671634
User impact if declined: Firefox uses non-tablet on tablets running Android 4.
Testing completed (on m-c, etc.): Landed on inbound Februrary 2.
Risk to taking this patch (and alternatives if risky): Extremely low risk. Trivial (one-line) XUL-fennec-only patch to fix an obvious regression.
String changes made by this patch: None.
Note: This patch should land on Aurora/Beta at the same time as bug 671634.
Attachment #593993 -
Flags: approval-mozilla-beta?
Attachment #593993 -
Flags: approval-mozilla-aurora?
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 4•13 years ago
|
||
Comment on attachment 593993 [details] [diff] [review]
patch
[Triage Comment]
Approved for Aurora 12 and Beta 11.
Attachment #593993 -
Flags: approval-mozilla-beta?
Attachment #593993 -
Flags: approval-mozilla-beta+
Attachment #593993 -
Flags: approval-mozilla-aurora?
Attachment #593993 -
Flags: approval-mozilla-aurora+
|
||
Comment 5•13 years ago
|
||
status-firefox11:
--- → fixed
|
|
||
Comment 6•13 years ago
|
||
|
|
Assignee | |
Comment 7•13 years ago
|
||
Comment on attachment 593993 [details] [diff] [review]
patch
Requesting approval-mozilla-esr10 because this patch blocks bug 671634. See bug 671634 comment 94 for details.
Attachment #593993 -
Flags: approval-mozilla-esr10?
|
||
Updated•13 years ago
|
status-firefox-esr10:
--- → affected
tracking-firefox-esr10:
--- → 12+
|
||
Comment 8•13 years ago
|
||
Comment on attachment 593993 [details] [diff] [review]
patch
[Triage Comment]
Android-only, low risk
Attachment #593993 -
Flags: approval-mozilla-esr10? → approval-mozilla-esr10+
|
|
Assignee | |
Comment 9•13 years ago
|
||
|
||
Comment 10•13 years ago
|
||
Tablet layout display on Asus Eee Transformers (Android 4.0.3) on build: Mozilla/5.0 (Android; Tablet; rv:10.0.4esrpre) Gecko/10.0.4es Firefox/10.0.4esrpre Fennec/10.0.4esrpre
You need to log in
before you can comment on or make changes to this bug.
Description
•