Created attachment 593993 [details] [diff] [review] patch Regression from bug 671634, which changed an nsSystemInfo property from "isTablet" to "tablet" without updating the existing code that used the property.
Attachment #593993 - Flags: review?(mark.finkle)
Attachment #593993 - Flags: review?(mark.finkle) → review+
Whiteboard: [has patch]
Target Milestone: --- → Firefox 13
Comment on attachment 593993 [details] [diff] [review] patch [Approval Request Comment] Regression caused by (bug #): bug 671634 User impact if declined: Firefox uses non-tablet on tablets running Android 4. Testing completed (on m-c, etc.): Landed on inbound Februrary 2. Risk to taking this patch (and alternatives if risky): Extremely low risk. Trivial (one-line) XUL-fennec-only patch to fix an obvious regression. String changes made by this patch: None. Note: This patch should land on Aurora/Beta at the same time as bug 671634.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Comment on attachment 593993 [details] [diff] [review] patch [Triage Comment] Approved for Aurora 12 and Beta 11.
status-firefox11: --- → fixed
tracking-fennec: ? → 11+
status-firefox12: --- → fixed
status-firefox13: --- → fixed
Comment on attachment 593993 [details] [diff] [review] patch Requesting approval-mozilla-esr10 because this patch blocks bug 671634. See bug 671634 comment 94 for details.
Attachment #593993 - Flags: approval-mozilla-esr10?
status-firefox-esr10: --- → affected
tracking-firefox-esr10: --- → 12+
Comment on attachment 593993 [details] [diff] [review] patch [Triage Comment] Android-only, low risk
Attachment #593993 - Flags: approval-mozilla-esr10? → approval-mozilla-esr10+
status-firefox-esr10: affected → fixed
Tablet layout display on Asus Eee Transformers (Android 4.0.3) on build: Mozilla/5.0 (Android; Tablet; rv:10.0.4esrpre) Gecko/10.0.4es Firefox/10.0.4esrpre Fennec/10.0.4esrpre
status-firefox-esr10: fixed → verified
You need to log in before you can comment on or make changes to this bug.