Closed
Bug 723767
Opened 13 years ago
Closed 13 years ago
IonMonkey: Fix nomethodjit build
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: dvander, Assigned: dvander)
Details
Attachments
(1 file)
|
4.31 KB,
patch
|
cdleary
:
review+
|
Details | Diff | Splinter Review |
Getting tbpl green.
Attachment #594020 -
Flags: review?(christopher.leary)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 594020 [details] [diff] [review]
fix
Review of attachment 594020 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsinfer.cpp
@@ +2229,3 @@
> #if defined(JS_METHODJIT)
> mjit::JITScript *jit = info.script->getJIT(info.constructing);
> + bool hasJITCode = jit && jit->chunkDescriptor(info.chunkIndex).chunk;
Hmm... is there a good place to document that defined(JS_ION) implies defined(JS_METHODJIT)? Maybe it doesn't matter.
Attachment #594020 -
Flags: review?(christopher.leary) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Probably not... if we ever get rid of JM, JS_ION should become JS_METHODJIT. IonMonkey depends on assembler/* too which is only built if JM is.
http://hg.mozilla.org/projects/ionmonkey/rev/3b67e0b8192d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•