Last Comment Bug 723767 - IonMonkey: Fix nomethodjit build
: IonMonkey: Fix nomethodjit build
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To: David Anderson [:dvander]
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-02-02 16:56 PST by David Anderson [:dvander]
Modified: 2012-02-03 16:14 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (4.31 KB, patch)
2012-02-02 16:56 PST, David Anderson [:dvander]
cdleary: review+
Details | Diff | Splinter Review

Description User image David Anderson [:dvander] 2012-02-02 16:56:00 PST
Created attachment 594020 [details] [diff] [review]

Getting tbpl green.
Comment 1 User image Chris Leary [:cdleary] (not checking bugmail) 2012-02-02 22:00:52 PST
Comment on attachment 594020 [details] [diff] [review]

Review of attachment 594020 [details] [diff] [review]:

::: js/src/jsinfer.cpp
@@ +2229,3 @@
>  #if defined(JS_METHODJIT)
>      mjit::JITScript *jit = info.script->getJIT(info.constructing);
> +    bool hasJITCode = jit && jit->chunkDescriptor(info.chunkIndex).chunk;

Hmm... is there a good place to document that defined(JS_ION) implies defined(JS_METHODJIT)? Maybe it doesn't matter.
Comment 2 User image David Anderson [:dvander] 2012-02-03 16:14:59 PST
Probably not... if we ever get rid of JM, JS_ION should become JS_METHODJIT. IonMonkey depends on assembler/* too which is only built if JM is.

Note You need to log in before you can comment on or make changes to this bug.