Last Comment Bug 723773 - Liveness analysis makes mistakes when analyzing try/catch
: Liveness analysis makes mistakes when analyzing try/catch
: regression
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla13
Assigned To: Bill McCloskey (:billm)
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 714645
  Show dependency treegraph
Reported: 2012-02-02 17:12 PST by Bill McCloskey (:billm)
Modified: 2012-07-11 20:00 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (4.02 KB, patch)
2012-02-02 17:12 PST, Bill McCloskey (:billm)
bhackett1024: review+
Details | Diff | Splinter Review

Description User image Bill McCloskey (:billm) 2012-02-02 17:12:52 PST
Created attachment 594024 [details] [diff] [review]

This was basically a mistake over the meaning of some arguments to the Lifetime constructor, I think. The fix is simple.

Most of the work of writing this patch was in figuring out the meaning of the savedEnd field, so I tried to improve the comment describing it. Let me know if you have any ideas for this.

I don't understand precisely how the JIT uses this information, so I decided to be conservative and close the bug.
Comment 1 User image Brian Hackett (:bhackett) 2012-02-02 17:26:02 PST
Comment on attachment 594024 [details] [diff] [review]

Review of attachment 594024 [details] [diff] [review]:


::: js/src/jsanalyze.cpp
@@ +1008,5 @@
> +     *
> +     * Each time we create a Lifetime, we store the start of the most recently
> +     * seen sequence of conditional code in the Lifetime's savedEnd field. So,
> +     * when creating the Lifetime at #2, we set the Lifetime's savedEnd to
> +     * #5. (The most start of the most recent conditional is cached in each

rm 'most'
Comment 3 User image Ed Morley [:emorley] 2012-02-10 19:56:31 PST
From philor:
Backed out in - one of the six in that push was crashing in js::gc::Mark<JSString>
Comment 5 User image Bill McCloskey (:billm) 2012-02-13 09:34:28 PST
Comment 6 User image Daniel Veditz [:dveditz] 2012-03-17 15:39:16 PDT
regression from bug 714645 which landed in Firefox 12 so we don't have to worry about ESR. Not sure if this is serious enough to warrant fixing on the beta branch.
Comment 7 User image Al Billings [:abillings] 2012-05-18 17:08:05 PDT
What security rating should be attached to this issue?
Comment 8 User image Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2012-05-29 11:30:23 PDT
Is there something QA can do to verify this fix?

Note You need to log in before you can comment on or make changes to this bug.