The default bug view has changed. See this FAQ.

rename nsAccessible::GetAllowsAnonChildAccessibles

RESOLVED FIXED in mozilla13

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: joseph)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla13
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
rename nsAccessible::GetAllowsAnonChildAccessibles to something more nice.

Options:
AreAnonChildrenAllowed - short but not too correct
CanHaveChildrenInAnonContent - doesn't describe that class expects or not expect the anonymous content be accessible
AreChildrenInAnonContentAllowed
AllowsChildrenInAnonContent

Trevor, ideas?
(In reply to alexander :surkov from comment #0)
> rename nsAccessible::GetAllowsAnonChildAccessibles to something more nice.
> 
> Options:
> AreAnonChildrenAllowed - short but not too correct
> CanHaveChildrenInAnonContent - doesn't describe that class expects or not
> expect the anonymous content be accessible
> AreChildrenInAnonContentAllowed
> AllowsChildrenInAnonContent

how about CanHaveChildrenForAnonContent()?

> Trevor, ideas?

how about kill it and use a bit in mFlags for the same purpose?
(Reporter)

Comment 2

5 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #1)
> (In reply to alexander :surkov from comment #0)
> > rename nsAccessible::GetAllowsAnonChildAccessibles to something more nice.
> > 
> > Options:
> > AreAnonChildrenAllowed - short but not too correct
> > CanHaveChildrenInAnonContent - doesn't describe that class expects or not
> > expect the anonymous content be accessible
> > AreChildrenInAnonContentAllowed
> > AllowsChildrenInAnonContent
> 
> how about CanHaveChildrenForAnonContent()?

mm, ok.

> > Trevor, ideas?
> 
> how about kill it and use a bit in mFlags for the same purpose?

somebody should run through implementations and make sure accessible is recreated when attribute are changed (it'd be nice to write mochitests). Anyway, if we see that accessible is not recreated then it can be a problem (in case if it's children dont' get updated).
(Reporter)

Comment 3

5 years ago
after chat on irc Trevor and I are fine with CanHaveAnonChildren() name.
(Assignee)

Comment 4

5 years ago
Created attachment 594702 [details] [diff] [review]
GetAllowsAnonChildAccessibles renamed to CanHaveAnonChildren
Attachment #594702 - Flags: review?(surkov.alexander)
(Reporter)

Comment 5

5 years ago
Comment on attachment 594702 [details] [diff] [review]
GetAllowsAnonChildAccessibles renamed to CanHaveAnonChildren

Review of attachment 594702 [details] [diff] [review]:
-----------------------------------------------------------------

it appears you didn't change all entries, for example, nsXULComboboxAccessible::GetAllowsAnonChildAccessibles()

::: accessible/src/base/nsAccessible.h
@@ +387,5 @@
>     */
>    virtual nsresult HandleAccEvent(AccEvent* aAccEvent);
>  
>    /**
>     * Return true if there are accessible children in anonymous content

while you're here then please change the comment like:
Return true if this accessible allows accessible children from anonymous subtree.

::: accessible/src/mac/nsAccessibleWrap.h
@@ +98,5 @@
>    /**
>     * Returns this accessible's all children, adhering to "flat" accessibles by 
>     * not returning their children.
>     */
> +  void GetUnignoredChildren(nsTArray< nsAccessibile* > & aChildrenArray);

why is this change?
Attachment #594702 - Flags: review?(surkov.alexander) → review-
(Assignee)

Comment 6

5 years ago
Created attachment 595165 [details] [diff] [review]
This time, all GetAllowsAnonChildAccessibles() methods renamed to CanHaveAnonChildren()
Attachment #594702 - Attachment is obsolete: true
Attachment #595165 - Flags: review?(surkov.alexander)
(Reporter)

Comment 7

5 years ago
Comment on attachment 595165 [details] [diff] [review]
This time, all GetAllowsAnonChildAccessibles() methods renamed to CanHaveAnonChildren()

Review of attachment 595165 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #595165 - Flags: review?(surkov.alexander) → review+
(Reporter)

Updated

5 years ago
Assignee: nobody → joey.blacksmith
(Reporter)

Comment 8

5 years ago
inbound land https://hg.mozilla.org/integration/mozilla-inbound/rev/417bf64cf918
https://hg.mozilla.org/mozilla-central/rev/417bf64cf918

Congratulations on your first patch in the tree! Hope to see you on IRC (http://irc.mozilla.org/) in #developers soon. If you'd like to fix another bug (we'd love it if you did!) but need some inspiration, pop on & say hi - and we'll find something for you :-)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
(Reporter)

Comment 10

5 years ago
(In reply to Ed Morley [:edmorley] from comment #9)
> https://hg.mozilla.org/mozilla-central/rev/417bf64cf918
> 
> Congratulations on your first patch in the tree! Hope to see you on IRC
> (http://irc.mozilla.org/) in #developers soon. If you'd like to fix another
> bug (we'd love it if you did!) but need some inspiration, pop on & say hi -
> and we'll find something for you :-)

and #accessibility channel too :)

Thanks, Joseph, for working on this!
You need to log in before you can comment on or make changes to this bug.