723803 - test recovery of old simple-storage data

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Brian Warner [:warner :bwarner]]

After discovering the simple-storage problems in bug 723012, we realized it'd be a good idea to have a test that confirms we can recover data stored with simple-storage from previous versions of the SDK. That means recording the save-data file created by simple-storage in e.g. 1.2, then have a test which populates a new profile with the preserved data, then check to see if we can recover it.

It might be easiest to test that with one of the examples/ rather than in packages/api-utils . Maybe add code to the test runner that looks for a "_saved-profile-data.json" file in the package directory, and if present, loads the contents and jams it into the profile somewhere, after mozrunner creates the profile, but before the tests are run.

Comment 1

[Dave Townsend [:mossop]]

Don't think this needs to wait for triage, this is super-important and I'd love to see it done for 1.5 if at all possible. Losing data is one of the things we should avoid at all costs and this helps us there.

Comment 2

[Tomislav Jovanovic :zombie]

is this still relevant? 

and if yes, is it a simple test of writing a json file to the "expected" place, loading the module, and verifying that all is well?

Comment 3

[Dave Townsend [:mossop]]

Yes and yes!

Comment 4

[Tomislav Jovanovic :zombie]

that seems simple enough..

Comment 5

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1467/files

Comment 6

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1467

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 8409155 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1467

Wonderful!

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/337cc748c00d128b01731e7ff105863090e67add
bug 723803 - test recovery of simple-storage data

https://github.com/mozilla/addon-sdk/commit/196d79e9c2c627031bd3fb2715e0612d88255c56
Merge pull request #1467 from zombie/723803-test-ss-recover

bug 723803 - test recovery of simple-storage data, r=@Mossop