Closed
Bug 723809
Opened 13 years ago
Closed 13 years ago
TestTArray.cpp:886:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
Build warning:
{
TestTArray.cpp: In function ‘bool TestTArray::test_fallible()’:
TestTArray.cpp:886:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}
|
Assignee | |
Comment 1•13 years ago
|
||
The warning is because "numArrays" is currently a signed int, and we compare it to the unsigned value 'i' here:
> for (PRUint32 i = 0; i < numArrays; i++) {
This patch makes numArrays unsigned & fixes the warning.
Attachment #594060 -
Flags: review?(justin.lebar+bug)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 594060 [details] [diff] [review]
fix
When I saw that there was a blocker on the TArray changes, I was really nervous! Phew. :)
Attachment #594060 -
Flags: review?(justin.lebar+bug) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Target Milestone: --- → mozilla13
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•