Note: There are a few cases of duplicates in user autocompletion which are being worked on.

TestTArray.cpp:886:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

RESOLVED FIXED in mozilla13

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

fix
1.06 KB, patch
Justin Lebar (not reading bugmail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Build warning:
{
TestTArray.cpp: In function ‘bool TestTArray::test_fallible()’:
TestTArray.cpp:886:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}
(Assignee)

Comment 1

6 years ago
Created attachment 594060 [details] [diff] [review]
fix

The warning is because "numArrays" is currently a signed int, and we compare it to the unsigned value 'i' here:
>   for (PRUint32 i = 0; i < numArrays; i++) {

This patch makes numArrays unsigned & fixes the warning.
Attachment #594060 - Flags: review?(justin.lebar+bug)
Comment on attachment 594060 [details] [diff] [review]
fix

When I saw that there was a blocker on the TArray changes, I was really nervous!  Phew.  :)
Attachment #594060 - Flags: review?(justin.lebar+bug) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/74cb806f25c2
Target Milestone: --- → mozilla13

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/74cb806f25c2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.