Closed Bug 723809 Opened 10 years ago Closed 10 years ago

TestTArray.cpp:886:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla13

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

fix
1.06 KB, patch
justin.lebar+bug
: review+
Details | Diff | Splinter Review 
Build warning:
{
TestTArray.cpp: In function ‘bool TestTArray::test_fallible()’:
TestTArray.cpp:886:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}
Attached patch fix — — Splinter Review 
The warning is because "numArrays" is currently a signed int, and we compare it to the unsigned value 'i' here:
>   for (PRUint32 i = 0; i < numArrays; i++) {

This patch makes numArrays unsigned & fixes the warning.
Attachment #594060 - Flags: review?(justin.lebar+bug)
Comment on attachment 594060 [details] [diff] [review]
fix

When I saw that there was a blocker on the TArray changes, I was really nervous!  Phew.  :)
Attachment #594060 - Flags: review?(justin.lebar+bug) → review+
https://hg.mozilla.org/mozilla-central/rev/74cb806f25c2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.