723809 - TestTArray.cpp:886:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
TestTArray.cpp: In function ‘bool TestTArray::test_fallible()’:
TestTArray.cpp:886:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}

Comment 1

[Daniel Holbert [:dholbert]]

Created attachment 594060 [details] [diff] [review]
fix

The warning is because "numArrays" is currently a signed int, and we compare it to the unsigned value 'i' here:
>   for (PRUint32 i = 0; i < numArrays; i++) {

This patch makes numArrays unsigned & fixes the warning.

Comment 2

[Justin Lebar (not reading bugmail)]

Comment on attachment 594060 [details] [diff] [review]
fix

When I saw that there was a blocker on the TArray changes, I was really nervous!  Phew.  :)

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/74cb806f25c2

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/74cb806f25c2