Closed
Bug 723852
Opened 13 years ago
Closed 13 years ago
Use a runnable for canvas.mozFetchAsStream()
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.62 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Bug 720697 comment #12:
> >+nsHTMLCanvasElement::MozFetchAsStream(nsIInputStreamCallback *aCallback,
>
> >+ return aCallback->OnInputStreamReady(asyncData);
>
> It's generally a bad idea to design an API to be async-friendly, but then
> invoke the callback synchronously - people can start depending on that,
> making your life difficult when it comes time to change it in the future.
> Can you use a runnable here?
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #594102 -
Flags: feedback?(khuey)
Comment on attachment 594102 [details] [diff] [review]
patch v1
Dispatching the callback on another thread is absolutely not what we want here.
Attachment #594102 -
Flags: feedback?(khuey) → feedback-
|
|
Assignee | |
Comment 3•13 years ago
|
||
Fresh patch, using the main thread.
Attachment #594102 -
Attachment is obsolete: true
Attachment #594145 -
Flags: review?(khuey)
Attachment #594145 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla13
|
|
Assignee | |
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in
before you can comment on or make changes to this bug.
Description
•