Bug 720697 comment #12: > >+nsHTMLCanvasElement::MozFetchAsStream(nsIInputStreamCallback *aCallback, > > >+ return aCallback->OnInputStreamReady(asyncData); > > It's generally a bad idea to design an API to be async-friendly, but then > invoke the callback synchronously - people can start depending on that, > making your life difficult when it comes time to change it in the future. > Can you use a runnable here?
Created attachment 594102 [details] [diff] [review] patch v1
Attachment #594102 - Flags: feedback?(khuey)
Comment on attachment 594102 [details] [diff] [review] patch v1 Dispatching the callback on another thread is absolutely not what we want here.
Attachment #594102 - Flags: feedback?(khuey) → feedback-
Created attachment 594145 [details] [diff] [review] patch v2 Fresh patch, using the main thread.
Attachment #594145 - Flags: review?(khuey) → review+
Target Milestone: --- → mozilla13
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.