Closed Bug 723864 Opened 11 years ago Closed 10 years ago

Remove dead default cases in gfx

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: espindola, Assigned: espindola)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Remove dead default cases in gfx (obsolete) — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=92c7fb526737
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #594106 - Flags: review?(jmuizelaar)
gcc cannot figure out that a switch covers all the values, so we depend on 723114. I have pushed a combined patch to try in

https://tbpl.mozilla.org/?tree=Try&rev=a2a0f4979b8d
https://tbpl.mozilla.org/?tree=Try&rev=805b7cac0030

Added a missing include :-(
Sorry for the noise.
Attachment #594106 - Attachment is obsolete: true
Attachment #594106 - Flags: review?(jmuizelaar)
Attachment #594116 - Flags: review?(jmuizelaar)
Comment on attachment 594116 [details] [diff] [review]
Remove dead default cases in gfx

I'm not thrilled with the addition of MOZ_NOT_REACHED() but if gcc needs it so be it.
Attachment #594116 - Flags: review?(jmuizelaar) → review+
Comment on attachment 594116 [details] [diff] [review]
Remove dead default cases in gfx

Review of attachment 594116 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxRect.h
@@ +130,2 @@
>          }
> +        MOZ_NOT_REACHED("Incomplet switch");

This should be "Incomplete switch".  Here and elsewhere in this patch.
A new combined patch is under test in

https://tbpl.mozilla.org/?tree=Try&rev=6c6023a4e8a3

I will push this one once the dependency is fixed.
https://hg.mozilla.org/mozilla-central/rev/9b88e7f2571c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.