723864 - Remove dead default cases in gfx

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Remove dead default cases in gfx

https://tbpl.mozilla.org/?tree=Try&rev=92c7fb526737

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

gcc cannot figure out that a switch covers all the values, so we depend on 723114. I have pushed a combined patch to try in

https://tbpl.mozilla.org/?tree=Try&rev=a2a0f4979b8d

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Remove dead default cases in gfx

https://tbpl.mozilla.org/?tree=Try&rev=805b7cac0030

Added a missing include :-(
Sorry for the noise.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 594116 [details] [diff] [review]
Remove dead default cases in gfx

I'm not thrilled with the addition of MOZ_NOT_REACHED() but if gcc needs it so be it.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 594116 [details] [diff] [review]
Remove dead default cases in gfx

Review of attachment 594116 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxRect.h
@@ +130,2 @@
>          }
> +        MOZ_NOT_REACHED("Incomplet switch");

This should be "Incomplete switch".  Here and elsewhere in this patch.

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

A new combined patch is under test in

https://tbpl.mozilla.org/?tree=Try&rev=6c6023a4e8a3

I will push this one once the dependency is fixed.

Comment 7

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=9b88e7f2571c

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/9b88e7f2571c