723917 - java.lang.NullPointerException at org.mozilla.gecko.GeckoApp.handleMessage(GeckoApp.java:908) when disabling Full Screen add-on

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Mozilla/5.0 (Android;Linux armv7l;rv:13.0a1)Gecko/20120203
Firefox/13.0a1 Fennec/13.0a1
Device: HTC Desire
OS: Android 2.2

Steps to reproduce:
1. Open Fennec
2. Go to addons.mozilla.org/en-US/android/
3. Install Full Screen add-on
4. Go to Add-ons Manager
5. Disable Full Screen Add-on

Expected result:
After step 5, Full screen add-on is visibly disabled. No errors should occur.

Actual result:
After step 5, Fennec is still in full screen mode. Also the following errors occur in logcat:

    I/GeckoApp(10588): Got message: Menu:Remove
    E/GeckoApp(10588): Exception handling message "Menu:Remove":
    E/GeckoApp(10588): java.lang.NullPointerException
    E/GeckoApp(10588):      at org.mozilla.gecko.GeckoApp.handleMessage(GeckoApp.java:908)
    E/GeckoApp(10588):      at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:1676)
    E/GeckoApp(10588):      at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
    E/GeckoApp(10588):      at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
    E/GeckoApp(10588):      at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:495)
    E/GeckoApp(10588):      at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:104)
    E/GeckoConsole(10588): [JavaScript Warning: "Duplicate resource declaration for 'gre-resources' ignored." {file: "jar:jar:file:///data/app/org.mozilla.fennec-1.apk!/omni.ja!/chrome/nonlocalized.manifest" line: 11}]
    E/GeckoConsole(10588): Could not read chrome manifest 'file:///data/data/org.mozilla.fennec/chrome.manifest'.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This fixes the NullPointerException.  I think the exception happened only if you have never pressed the Menu key since Fennec was launched.

There's still a separate bug that Fennec does not exit full-screen mode when the add-on is disabled.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 594256 [details] [diff] [review]
patch

This looks good to me.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/mozilla-central/rev/766a59650976

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 594256 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: Crash when enabling/disabling add-ons
Testing completed (on m-c, etc.): Needs to be verified
Risk to taking this patch (and alternatives if risky): Low

Comment 5

[Matt Brubeck (:mbrubeck)]

(In reply to Matt Brubeck (:mbrubeck) from comment #1)
> There's still a separate bug that Fennec does not exit full-screen mode when
> the add-on is disabled.

This was a bug in the add-on itself; see bug 723977.

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 594256 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 7

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-02-05)
20120205031129
http://hg.mozilla.org/mozilla-central/rev/ccbb41b873cd
Device: HTC Desire
OS: Android 2.2

Comment 8

[Scoobidiver (away)]

Not yet landed in Fx 11 and 12.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f68ab5b1ce7a

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/826ada574fab

Comment 11

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 12.0a2 (2012-02-07)
20120207042017
http://hg.mozilla.org/releases/mozilla-aurora/rev/cd3f31d128b8
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 11.0
20120206202409
http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116
Device: HTC Desire Z
OS: Android 2.3.3