Avoid access to uninitialized mLastPaintEndTime

RESOLVED FIXED in mozilla13

Status

()

Core
Widget
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla13
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 594175 [details] [diff] [review]
fix v1.0

I often hit an assertion that mLastPaintEndTime is uninitialized in DispatchPendingEvents on Wine. While there may be a bug in Wine that causes different message sequence that is not observed on Windows, I don't see a reason to believe that it will be set in OnPaint before an attempt to access it, so AFAICT it may happen on Windows as well. The attached patch initializes mLastPaintEndTime in nsWindow constructor.
Attachment #594175 - Flags: review?(roc)
Attachment #594175 - Flags: review?(roc) → review+
(Assignee)

Comment 1

6 years ago
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3821d8e96981

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/3821d8e96981
Assignee: nobody → jacek
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.