Last Comment Bug 723929 - Avoid access to uninitialized mLastPaintEndTime
: Avoid access to uninitialized mLastPaintEndTime
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget (show other bugs)
: Trunk
: x86 Windows XP
: -- normal (vote)
: mozilla13
Assigned To: Jacek Caban
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-03 07:08 PST by Jacek Caban
Modified: 2012-02-07 12:20 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1.0 (908 bytes, patch)
2012-02-03 07:08 PST, Jacek Caban
roc: review+
Details | Diff | Splinter Review

Description Jacek Caban 2012-02-03 07:08:29 PST
Created attachment 594175 [details] [diff] [review]
fix v1.0

I often hit an assertion that mLastPaintEndTime is uninitialized in DispatchPendingEvents on Wine. While there may be a bug in Wine that causes different message sequence that is not observed on Windows, I don't see a reason to believe that it will be set in OnPaint before an attempt to access it, so AFAICT it may happen on Windows as well. The attached patch initializes mLastPaintEndTime in nsWindow constructor.
Comment 1 Jacek Caban 2012-02-06 02:28:18 PST
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3821d8e96981
Comment 2 Ed Morley [:emorley] 2012-02-07 12:20:25 PST
https://hg.mozilla.org/mozilla-central/rev/3821d8e96981

Note You need to log in before you can comment on or make changes to this bug.