724030 - Contenteditable demo doesn't work with February 3rd Nightly

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Bill Gianopoulos [:WG9s]]

This testcase, attachment 591893 [details] from bug 721484, does not work at all with today's nightly.  Works fine with yesterday's.  I am doing a bisect to determine what changed.

Comment 1

[Wesley Johnston (:wesj)]

Is this in XUL or Native?

Comment 2

[Bill Gianopoulos [:WG9s]]

Native.

Comment 3

[Wesley Johnston (:wesj)]

I think I know the issue here. In this case, the page has touch event listeners so we're going to delay panning until we've heard back from them. We also don't really care what they say on touchdown because they can still prevent panning on the first touchmove event.

However, we don't send the first touchmove until they've moved their finger a certain minimum distance (Google maps needs that to work). Since touchmove never fires, we never create our timer that would tell us its ok to fire off the events. If you move your finger enough to trigger touchmove (and the timer), we're no longer in a situation where we'll fire mouse events.

My solution is to check for this on touchup. If your finger hasn't moved far enough to fire a touchmove, we kick off the timer as well...

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

This fixes this for me. We still have some issues with double tap zoom and touch events, but I think they're unrelated to this.

Comment 5

[Bill Gianopoulos [:WG9s]]

(In reply to Wesley Johnston (:wesj) from comment #4)
> Created attachment 594334 [details] [diff] [review]
> Patch
> 
> This fixes this for me. We still have some issues with double tap zoom and
> touch events, but I think they're unrelated to this.

Fixes it for me also.

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b937df325e71

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 594334 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): 603008 multitouch
User impact if declined: impossible to click on pages that have touch event listeners, but that are relying on mouse events to also fire
Testing completed (on m-c, etc.): landed on mc today (2/6)
Risk to taking this patch (and alternatives if risky): Low risk. Mobile only.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b937df325e71

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 594334 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 10

[Matt Brubeck (:mbrubeck)]

Comment on attachment 594334 [details] [diff] [review]
Patch

Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions.  If this changes in the future, we will likely do a mass uplift of all native fennec changes.  For now, let's get these bugs off the channel triage radar.

[Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]