The default bug view has changed. See this FAQ.

Broken link to Mozilla Manifesto on about:mozilla page in Firefox

RESOLVED FIXED in Firefox 13

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Terry R., Assigned: lmanuelab)

Tracking

unspecified
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=felipe])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
In Firefox, type about:mozilla in address bar.
"sacred words" links to http://www.mozilla.org/about/mozilla-manifesto.html and is 404.  http://www.mozilla.org/about/manifesto.html works.

Comment 1

5 years ago
Thanks for reporting.  Fixed in r101093.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 2

5 years ago
Reopening.  I realize that the mozilla.org/book page is not that page that is being called up by about:mozilla in Firefox.  That must be a legacy page that is not in use now.

This should be reassigned to the Firefox product where someone will know how to update the link in that page.
Status: RESOLVED → REOPENED
Component: www.mozilla.org → General
Product: Websites → Firefox
QA Contact: www-mozilla-org → general
Resolution: FIXED → ---
Summary: about:mozilla 404 link to manifesto → Broken link to Mozilla Manifesto on about:mozilla page in Firefox
http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/mozilla.dtd#8
Also see http://mxr.mozilla.org/mozilla-central/source/toolkit/content/mozilla.xhtml

Current preference is to not localize links, but handle that serverside.

The fix here should be to:

* Split up &mozilla.quote; into multiple chunks
* Change mozilla.xhtml to include <a href="..."> and use the multiple chunks

Eg

&foo1;<a href="bar.html">&foo2;</a>&foo3;<a href="baz.html">&foo4;</a>&foo5;

The chunks are needed to locales can split text as needed, some chunks may even be empty.
Whiteboard: [good first bug]
Status: REOPENED → NEW
Whiteboard: [good first bug] → [good first bug][mentor=felipe]
Guacamole, what "needs" to be fixed here is the URL only, but what Dolske is suggesting is that while we are at it we should split that long text into multiple segments because that's how this is usually done, and it makes it easier to maintain in the future.

See an example here: http://mxr.mozilla.org/mozilla-central/source/testing/extensions/community/chrome/content/tabs/chat.xul#71
Think about how the whole content inside the <li> could have been a single entity, however there are 2 "&..." (entities) there because they are the logical units here.

So what you need to do is to split the text in the dtd into various parts:
"part before the url", "the url", "the url name", "part of the url"..

and then also change mozilla.xhtml to use all these entities, instead of just &mozilla.quote as it does now
(Assignee)

Comment 6

5 years ago
Created attachment 600123 [details] [diff] [review]
about:mozilla
Attachment #600123 - Flags: review?(felipc)
Comment on attachment 600123 [details] [diff] [review]
about:mozilla

This is looking good, thanks for the patch! There's still a few changes that we should do before reviewing:

- Whenever we change a string, due to the way the localization process works, we need to change its name too. You can just add a 2, changing mozilla.quote to mozilla.quote2.

- You can keep the markup and the text (sacred words/spoke) inside the same quote. Let's just move the actual URLs to new entities and then reference them inside the <a href="...">

- Please declare the URL entities before the quote (just for clarity)
Attachment #600123 - Flags: review?(felipc) → feedback+
OK now really.  No matter what is done here to fix this long term and correctly, the links in the release version will still be broken.  I doubt there is going to be a 10.0.3 to fix this.  I also bet it is to far into the beta cycle to get a fix here into version 11.  The obvious short term thing to do is to make do a server-side change to make the link in the current release Firefox just work.

I would really wish the people resisting doing this would explain their reasoning for their position.
(Assignee)

Comment 9

5 years ago
Created attachment 600313 [details] [diff] [review]
aboutMozillaPatch2
Attachment #600313 - Flags: review?(felipc)
Comment on attachment 600313 [details] [diff] [review]
aboutMozillaPatch2

Looks perfect, thanks!

We should also file a bug to get the URL on the server-side to do proper locale redirection, and see if this is the final URL that Webdev wants to have the manifesto hosted.

WG9s: mozilla.org went through some big changes recently and even if we get a server-side redirect to fix this for the current releases (can you file a bug on that?), it's better to have the product pointing to the correct new URI.
Attachment #600313 - Flags: review?(felipc) → review+
Assignee: nobody → lmanuelab
Status: NEW → ASSIGNED
Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11af9adc0e5d
Fixed in mozilla-central for Firefox 13.  This fix should be included in tomorrow's Nightly build.  Thanks!
https://hg.mozilla.org/mozilla-central/rev/11af9adc0e5d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13

Comment 13

5 years ago
This was backed out but not mentioned so here is the changeset: https://hg.mozilla.org/mozilla-central/rev/825a808d224f

Updated

5 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 735404
Fixed by Bug 735404
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.