Closed Bug 724145 Opened 9 years ago Closed 9 years ago

telemetry for search hijacking

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 13
Tracking Status
firefox11 --- fixed
firefox12 --- fixed

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

See bug 718088. We'd like to gather some preliminary telemetry data to try and gauge how common it is for users to have user-set values for keyword.URL.
Attached patch patchSplinter Review
This is the simple first step - just indicate whether there's a user-set value or not.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #594355 - Flags: review?(jwein)
Comment on attachment 594355 [details] [diff] [review]
patch

Review of attachment 594355 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks for requesting review :)
Attachment #594355 - Flags: review?(jwein) → review+
https://hg.mozilla.org/mozilla-central/rev/841b4395aa66
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 594355 [details] [diff] [review]
patch

I'd like to take this on Aurora/Beta to get some more data before we move on to implementation in bug 718088. Risk is very low, it's just a simple pref check and telemetry addition. No string changes.
Attachment #594355 - Flags: approval-mozilla-beta?
Attachment #594355 - Flags: approval-mozilla-aurora?
Comment on attachment 594355 [details] [diff] [review]
patch

[Triage Comment]
Telemetry additions are high-reward and low-risk, so approving for Aurora 12 and Beta 11.
Attachment #594355 - Flags: approval-mozilla-beta?
Attachment #594355 - Flags: approval-mozilla-beta+
Attachment #594355 - Flags: approval-mozilla-aurora?
Attachment #594355 - Flags: approval-mozilla-aurora+
Is there something QA can do to verify this bug?
Whiteboard: [qa?]
No
Whiteboard: [qa?] → [qa-]
You need to log in before you can comment on or make changes to this bug.