"visit count" bookmark AppleScript property broken in 2.1

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: alqahira, Assigned: alqahira)

Tracking

(Blocks: 1 bug, {regression})

unspecified
All
Mac OS X
regression
Dependency tree / graph
Bug Flags:
camino2.1.1 +

Details

(Whiteboard: [camino-2.1.1])

Attachments

(1 attachment)

Created attachment 594391 [details] [diff] [review]
Update sdef to match code

When Stuart unified the Bookmarks and History visit count interfaces in bug 642427, he forgot to change the cocoaKey element in the .sdef to match.

This currently causes an exception when the property is accessed:

Warning An exception was thrown during execution of an NSScriptCommand... 
Warning [<Bookmark 0x13e1dbe0> valueForUndefinedKey:]: this class is not key value coding-compliant for the key numberOfVisits.

Luckily, this is a true 1-liner to fix!  We should take it in 2.1.1.

(:sigh: Bug 453202 :sigh:  Sadly, this is twice now this has been broken, though the last time--bug 512628--wasn't really our fault.)

(Lisa, if anyone's complained about your "Show Bookmark Usage" script not working in 2.1, this is why :P )
Attachment #594391 - Flags: superreview?(stuart.morgan+bugzilla)
Flags: camino2.1.1+

Comment 1

7 years ago
Comment on attachment 594391 [details] [diff] [review]
Update sdef to match code

Sorry :(

sr=smorgan
Attachment #594391 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
http://hg.mozilla.org/camino/rev/301fe151ff94
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.1.1]
You need to log in before you can comment on or make changes to this bug.