Closed
Bug 724204
Opened 13 years ago
Closed 13 years ago
"visit count" bookmark AppleScript property broken in 2.1
Categories
(Camino Graveyard :: OS Integration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: alqahira)
References
Details
(Keywords: regression, Whiteboard: [camino-2.1.1])
Attachments
(1 file)
|
1.07 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
When Stuart unified the Bookmarks and History visit count interfaces in bug 642427, he forgot to change the cocoaKey element in the .sdef to match.
This currently causes an exception when the property is accessed:
Warning An exception was thrown during execution of an NSScriptCommand...
Warning [<Bookmark 0x13e1dbe0> valueForUndefinedKey:]: this class is not key value coding-compliant for the key numberOfVisits.
Luckily, this is a true 1-liner to fix! We should take it in 2.1.1.
(:sigh: Bug 453202 :sigh: Sadly, this is twice now this has been broken, though the last time--bug 512628--wasn't really our fault.)
(Lisa, if anyone's complained about your "Show Bookmark Usage" script not working in 2.1, this is why :P )
Attachment #594391 -
Flags: superreview?(stuart.morgan+bugzilla)
Flags: camino2.1.1+
|
||
Comment 1•13 years ago
|
||
Comment on attachment 594391 [details] [diff] [review]
Update sdef to match code
Sorry :(
sr=smorgan
Attachment #594391 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.1.1]
You need to log in
before you can comment on or make changes to this bug.
Description
•