724221 - ScriptFactory SetProperty step fails on Windows

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Aki Sasaki (not active)]

http://hg.mozilla.org/build/buildbotcustom/file/5a2cb72a051a/process/factory.py#l8269

This fails on Windows test slaves; I'm not sure if it works on Windows build slaves.

I'm not sure if we're using ScriptFactory much on Windows.  We will be doing so much more when talos and unit tests are all ported to mozharness.

Comment 1

[Aki Sasaki (not active)]

Attachment: fix windows setproperties

@jhopkins, your basedir cmd /C fix worked.  The SetProperties portion didn't, but only because you modified self.get_basedir_cmd instead of cmd.

Comment 2

[Aki Sasaki (not active)]

Attachment: fix peptest reboots

'mozharness_python' is a list for Windows; the command line comes out like this:

"['c:/mozilla-build/python25/python', '-u']" 'build/tools/buildfarm/maintenance/count_and_reboot.py' '-f' '../reboot_count.txt' '-n' '1' '-z'

This patch should fix it.

Comment 3

[Rail Aliiev [:rail]]

(In reply to Aki Sasaki [:aki] from comment #0)
> This fails on Windows test slaves; I'm not sure if it works on Windows build
> slaves.
> 
> I'm not sure if we're using ScriptFactory much on Windows.  We will be doing
> so much more when talos and unit tests are all ported to mozharness.

It works fine on win32 build slaves (we use ScriptFactory for release l10n repacks).

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 632870 [details] [diff] [review]
fix peptest reboots

http://hg.mozilla.org/build/buildbot-configs/rev/07a92dd78fec

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 632869 [details] [diff] [review]
fix windows setproperties

http://hg.mozilla.org/build/buildbotcustom/rev/5815f37c9124

Comment 6

[Chris AtLee [:catlee]]

deployed to production

Comment 7

[Aki Sasaki (not active)]

This didn't work :(
The next fix needs moar testing.

Comment 8

[Aki Sasaki (not active)]

Attachment: fix peptest reboots part 2

Oops. =\

Comment 9

[Aki Sasaki (not active)]

Comment on attachment 633227 [details] [diff] [review]
fix peptest reboots part 2

http://hg.mozilla.org/build/buildbot-configs/rev/2a13bc315972

Comment 10

[Rail Aliiev [:rail]]

Landed on production today

Comment 11

[Aki Sasaki (not active)]

And I see a green peptest run with the script run properly, set properties working, and the reboot going through.