Closed Bug 724221 Opened 11 years ago Closed 10 years ago

ScriptFactory SetProperty step fails on Windows

Categories

(Release Engineering :: General, defect, P3)

x86
Windows Server 2003
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aki, Assigned: aki)

References

Details

(Whiteboard: [automation][mozharness])

Attachments

(3 files)

http://hg.mozilla.org/build/buildbotcustom/file/5a2cb72a051a/process/factory.py#l8269

This fails on Windows test slaves; I'm not sure if it works on Windows build slaves.

I'm not sure if we're using ScriptFactory much on Windows.  We will be doing so much more when talos and unit tests are all ported to mozharness.
Blocks: 747457
@jhopkins, your basedir cmd /C fix worked.  The SetProperties portion didn't, but only because you modified self.get_basedir_cmd instead of cmd.
Assignee: nobody → aki
Attachment #632869 - Flags: review?(jhopkins)
'mozharness_python' is a list for Windows; the command line comes out like this:

"['c:/mozilla-build/python25/python', '-u']" 'build/tools/buildfarm/maintenance/count_and_reboot.py' '-f' '../reboot_count.txt' '-n' '1' '-z'

This patch should fix it.
Attachment #632870 - Flags: review?(rail)
Blocks: 729929
(In reply to Aki Sasaki [:aki] from comment #0)
> This fails on Windows test slaves; I'm not sure if it works on Windows build
> slaves.
> 
> I'm not sure if we're using ScriptFactory much on Windows.  We will be doing
> so much more when talos and unit tests are all ported to mozharness.

It works fine on win32 build slaves (we use ScriptFactory for release l10n repacks).
Attachment #632870 - Flags: review?(rail) → review+
Attachment #632869 - Flags: review?(jhopkins) → review+
deployed to production
This didn't work :(
The next fix needs moar testing.
Oops. =\
Attachment #633227 - Flags: review?(rail)
Attachment #633227 - Flags: review?(rail) → review+
Landed on production today
And I see a green peptest run with the script run properly, set properties working, and the reboot going through.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.