Optimize move file calls on Windows, saving about 2ms per call (1 call on startup)

RESOLVED FIXED in mozilla13

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

unspecified
mozilla13
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch Patch v1.Splinter Review
In 2007, bug 375778 added the flag MOVEFILE_WRITE_THROUGH. This flag wasn't needed by the description of the problem in that bug though.

This flag causes the cache manager to flush the data to disk before returning.  

There is no benefit as far as consistency of the file data with subsequent calls though and we shouldn't do it from our file API because it incurs a cost of ~2ms.
Attachment #594445 - Flags: review?(benjamin)
Depends on: 375778
Attachment #594445 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/8787499fae84
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.