Closed Bug 724257 Opened 8 years ago Closed 8 years ago

Upload lightning in |make upload| if MOZ_CALENDAR is specified, for tryserver

Categories

(Calendar :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

Attached patch Fix - v1 β€” β€” Splinter Review
I wanted to do some try builds lately, just to find out again that I can't do so without hacking the upload target.

I obviously haven't tested this aside from calling the targets, and it also needs an extra set of eyes since I modified the upload behavior in the lightning-packager and this will affect release/l10n builds.

Is this sufficient to get the tryserver to upload lightning packages too?


If there is an easier way than adding a mozconfig-extra file to make try automatically build lightning, I would also appreciate pointers. In my ideal world I'd like to just add arguments to the try commit comment to make lightning build.
Attachment #594446 - Flags: review?(mbanner)
Just tested this on the tryserver, and at least for that case it seems to work. 

http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1328462869.1328466864.22317.gz&fulltext=1

Windows/Mac still pending.
Status: NEW → ASSIGNED
Attachment #594446 - Flags: review?(mbanner) → review+
Pushed to comm-central changeset 3ed870bf0b17
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
(In reply to Philipp Kewisch [:Fallen] from comment #0)
> If there is an easier way than adding a mozconfig-extra file to make try

Please revert this added part from your committed changeset (asap).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
OMG I'm sorry about that! I still had it in from testing :-(

comm-central changeset 8f6ef3a01d41
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
There is a typo that caused the wrong binary to be used on mac. I will push a change to all branches now:
Pushed to comm-central changeset 8a247aaa193c
Target Milestone: 1.5 → 1.7
Backported to releases/comm-aurora changeset 9e45d695ec54
Target Milestone: 1.7 → 1.6
Backported to releases/comm-beta changeset 5a01c9c5e609
Target Milestone: 1.6 → 1.5
You need to log in before you can comment on or make changes to this bug.