724257 - Upload lightning in |make upload| if MOZ_CALENDAR is specified, for tryserver

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

I wanted to do some try builds lately, just to find out again that I can't do so without hacking the upload target.

I obviously haven't tested this aside from calling the targets, and it also needs an extra set of eyes since I modified the upload behavior in the lightning-packager and this will affect release/l10n builds.

Is this sufficient to get the tryserver to upload lightning packages too?


If there is an easier way than adding a mozconfig-extra file to make try automatically build lightning, I would also appreciate pointers. In my ideal world I'd like to just add arguments to the try commit comment to make lightning build.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Just tested this on the tryserver, and at least for that case it seems to work. 

http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1328462869.1328466864.22317.gz&fulltext=1

Windows/Mac still pending.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central changeset 3ed870bf0b17

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to Philipp Kewisch [:Fallen] from comment #0)
> If there is an easier way than adding a mozconfig-extra file to make try

Please revert this added part from your committed changeset (asap).

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

OMG I'm sorry about that! I still had it in from testing :-(

comm-central changeset 8f6ef3a01d41

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

There is a typo that caused the wrong binary to be used on mac. I will push a change to all branches now:

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central changeset 8a247aaa193c

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Backported to releases/comm-aurora changeset 9e45d695ec54

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Backported to releases/comm-beta changeset 5a01c9c5e609