Simplify nsHTMLCSSUtils::GetDefaultViewCSS

RESOLVED FIXED in mozilla13

Status

()

Core
Editor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 594459 [details] [diff] [review]
Patch v1
Attachment #594459 - Flags: review?(ehsan)
Comment on attachment 594459 [details] [diff] [review]
Patch v1

Review of attachment 594459 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLCSSUtils.cpp
@@ +593,3 @@
>    NS_ENSURE_TRUE(element, NS_ERROR_NULL_POINTER);
>  
> +  nsCOMPtr<nsIDOMWindow> window = element->OwnerDoc()->GetWindow();

Please add a check to return a failure code if |window| is null here.
Attachment #594459 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/26360de1d1d8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.