Last Comment Bug 724268 - Simplify nsHTMLCSSUtils::GetDefaultViewCSS
: Simplify nsHTMLCSSUtils::GetDefaultViewCSS
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla13
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Makoto Kato [:m_kato]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-04 08:08 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-02-10 04:33 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (2.57 KB, patch)
2012-02-04 08:08 PST, :Ms2ger (⌚ UTC+1/+2)
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-02-04 08:08:42 PST
Created attachment 594459 [details] [diff] [review]
Patch v1
Comment 1 :Ehsan Akhgari 2012-02-06 11:35:33 PST
Comment on attachment 594459 [details] [diff] [review]
Patch v1

Review of attachment 594459 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLCSSUtils.cpp
@@ +593,3 @@
>    NS_ENSURE_TRUE(element, NS_ERROR_NULL_POINTER);
>  
> +  nsCOMPtr<nsIDOMWindow> window = element->OwnerDoc()->GetWindow();

Please add a check to return a failure code if |window| is null here.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-02-10 04:33:09 PST
https://hg.mozilla.org/mozilla-central/rev/26360de1d1d8

Note You need to log in before you can comment on or make changes to this bug.