Last Comment Bug 724275 - fix -Wswitch warnings
: fix -Wswitch warnings
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All Linux
: -- normal (vote)
: mozilla13
Assigned To: Nathan Froyd [:froydnj]
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-04 09:20 PST by Nathan Froyd [:froydnj]
Modified: 2012-02-06 00:49 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (5.25 KB, patch)
2012-02-04 09:24 PST, Nathan Froyd [:froydnj]
jmuizelaar: review+
Details | Diff | Splinter Review

Description Nathan Froyd [:froydnj] 2012-02-04 09:20:09 PST
GCC complains about switches over enums that don't have default cases.  In the interest of reducing warnings, these switches should be fixed.
Comment 1 Nathan Froyd [:froydnj] 2012-02-04 09:24:35 PST
Created attachment 594465 [details] [diff] [review]
patch

Simple patch.  It seemed better to eliminate the duplicate code in SourceSurfaceCairo.cpp than fixing the switches.
Comment 2 Mozilla RelEng Bot 2012-02-04 09:48:54 PST
Autoland Patchset:
	Patches: 594465
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/388039878d56
Try run started, revision 388039878d56. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=388039878d56
Comment 3 Mozilla RelEng Bot 2012-02-04 14:30:26 PST
Try run for 388039878d56 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=388039878d56
Results (out of 208 total builds):
    success: 186
    warnings: 21
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-388039878d56
Comment 5 Marco Bonardo [::mak] 2012-02-06 00:49:42 PST
https://hg.mozilla.org/mozilla-central/rev/f993c394c664

Note You need to log in before you can comment on or make changes to this bug.