fix -Wswitch warnings

RESOLVED FIXED in mozilla13

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

Trunk
mozilla13
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
GCC complains about switches over enums that don't have default cases.  In the interest of reducing warnings, these switches should be fixed.
(Assignee)

Comment 1

6 years ago
Created attachment 594465 [details] [diff] [review]
patch

Simple patch.  It seemed better to eliminate the duplicate code in SourceSurfaceCairo.cpp than fixing the switches.
Attachment #594465 - Flags: review?(jmuizelaar)
Attachment #594465 - Flags: review?(jmuizelaar) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Whiteboard: [autoland-try]

Updated

6 years ago
Whiteboard: [autoland-try] → [autoland-in-queue]

Comment 2

6 years ago
Autoland Patchset:
	Patches: 594465
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/388039878d56
Try run started, revision 388039878d56. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=388039878d56

Comment 3

6 years ago
Try run for 388039878d56 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=388039878d56
Results (out of 208 total builds):
    success: 186
    warnings: 21
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-388039878d56

Updated

6 years ago
Whiteboard: [autoland-in-queue]

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f993c394c664
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → mozilla13
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/f993c394c664
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.