724286 - Fix TelemetryTimestamps, AddonManagerPrivate global scope pollution and whitelist __SSi

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 594478 [details] [diff] [review]
patch

Review of attachment 594478 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.js
@@ +139,5 @@
>  
>  __defineGetter__("AddonManager", function() {
> +  let tmp = {};
> +  Cu.import("resource://gre/modules/AddonManager.jsm", tmp);
> +  return this.AddonManager = tmp.AddonManager;

why can't you pass 'this' to Cu.import()?

r=me otherwise

Comment 3

[:Gavin Sharp [email: [e-mail]]]

AddonManager.jsm exports another symbol (AddonManagerPrivate).

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Which seems to be required by tests:

https://tbpl.mozilla.org/php/getParsedLog.php?id=9104264&tree=Try

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/75a63510cbcf

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/75a63510cbcf