Closed
Bug 724286
Opened 12 years ago
Closed 12 years ago
Fix TelemetryTimestamps, AddonManagerPrivate global scope pollution and whitelist __SSi
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 13
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
3.88 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Comment on attachment 594478 [details] [diff] [review] patch Review of attachment 594478 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/browser.js @@ +139,5 @@ > > __defineGetter__("AddonManager", function() { > + let tmp = {}; > + Cu.import("resource://gre/modules/AddonManager.jsm", tmp); > + return this.AddonManager = tmp.AddonManager; why can't you pass 'this' to Cu.import()? r=me otherwise
Attachment #594478 -
Flags: review?(dietrich) → review+
Comment 3•12 years ago
|
||
AddonManager.jsm exports another symbol (AddonManagerPrivate).
Comment 4•12 years ago
|
||
Which seems to be required by tests: https://tbpl.mozilla.org/php/getParsedLog.php?id=9104264&tree=Try
Assignee | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/75a63510cbcf
Summary: Fix TelemetryTimestamps, AddonManagerPrivate global scope pollution → Fix TelemetryTimestamps, AddonManagerPrivate global scope pollution and whitelist __SSi
Target Milestone: --- → Firefox 13
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75a63510cbcf
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•