The default bug view has changed. See this FAQ.

Fix TelemetryTimestamps, AddonManagerPrivate global scope pollution and whitelist __SSi

RESOLVED FIXED in Firefox 13

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Blocks: 715402
(Assignee)

Comment 1

5 years ago
Created attachment 594478 [details] [diff] [review]
patch
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #594478 - Flags: review?(dietrich)
Comment on attachment 594478 [details] [diff] [review]
patch

Review of attachment 594478 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.js
@@ +139,5 @@
>  
>  __defineGetter__("AddonManager", function() {
> +  let tmp = {};
> +  Cu.import("resource://gre/modules/AddonManager.jsm", tmp);
> +  return this.AddonManager = tmp.AddonManager;

why can't you pass 'this' to Cu.import()?

r=me otherwise
Attachment #594478 - Flags: review?(dietrich) → review+
AddonManager.jsm exports another symbol (AddonManagerPrivate).
Which seems to be required by tests:

https://tbpl.mozilla.org/php/getParsedLog.php?id=9104264&tree=Try
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/75a63510cbcf
Summary: Fix TelemetryTimestamps, AddonManagerPrivate global scope pollution → Fix TelemetryTimestamps, AddonManagerPrivate global scope pollution and whitelist __SSi
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/mozilla-central/rev/75a63510cbcf
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.