724336 - SeaMonkey News XML causes errors

Status: RESOLVED FIXED

(SeaMonkey :: Website, defect)

Description

[Justin Wood (:Callek)]

Attachment: do it

So, for the SeaMonkey 2.7 final push we got news.en.xml errors again, and no easy fix then to trim data from the file....

And again with 2.8.

I found a fix that seems to work.... I split news.en.xml to news.en.xml and news2.en.xml and only using news2 for the full news archive page. (we don't need it in the atom, if I keep only old items there)

Patch attached was already pushed, but I want Jens to have a look at it.

Also I managed to get the errors (and updates) posting to seamonkey-release@m.o with the help of dumitru

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 594513 [details] [diff] [review]
do it

(In reply to Justin Wood (:Callek) from comment #0)
> I found a fix that seems to work.... I split news.en.xml to news.en.xml and
> news2.en.xml and only using news2 for the full news archive page. (we don't
> need it in the atom, if I keep only old items there)

I'm far from an expert in the field here (the stuff was not done by me and I know little about TT), but it looks like simple c&p. And hey, if it works, who am I to blame the one fixed it? :-) So, looks good to me, nice approach, r=me.

I just wonder what you chose as a cut-off date. Neither are all 2.1 bits in the old file, nor are all 2.0 bits in the new file. Anyway, we can move stuff around easily.

[The new news2.en.xml file is missing from the diff and you didn't post the checkin lines, but I verified that it's in the repo.]

> Also I managed to get the errors (and updates) posting to
> seamonkey-release@m.o with the help of dumitru

So now you got something? If so, any chance of getting me hooked onto that address?

Comment 2

[Justin Wood (:Callek)]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #1)
> Comment on attachment 594513 [details] [diff] [review]
> do it
> 
> (In reply to Justin Wood (:Callek) from comment #0)
> > I found a fix that seems to work.... I split news.en.xml to news.en.xml and
> > news2.en.xml and only using news2 for the full news archive page. (we don't
> > need it in the atom, if I keep only old items there)
> 
> I'm far from an expert in the field here (the stuff was not done by me and I
> know little about TT), but it looks like simple c&p. And hey, if it works,
> who am I to blame the one fixed it? :-) So, looks good to me, nice approach,
> r=me.

Yea, I just did mostly c&p then pushed it and hoped for the best as well :-)

> I just wonder what you chose as a cut-off date. Neither are all 2.1 bits in
> the old file, nor are all 2.0 bits in the new file. Anyway, we can move
> stuff around easily.

Mostly a "Hrm this looks like roughly half the file, and I know nothing older than this needs to be on front page or the atom feed. approximation, I did not think too long on that, feel free to play with it if you want, I'm not picky.

> > Also I managed to get the errors (and updates) posting to
> > seamonkey-release@m.o with the help of dumitru
> 
> So now you got something? If so, any chance of getting me hooked onto that
> address?

Yea, we got it, and it looks like the |build/full_build| is Modified locally, so we're getting 1 e-mail every 10 minutes until thats fixed, and its not "great" in terms of verbosity of the error, but either way, happy to add you.

The list does give more data than just this, but you can theoretically filter everything else out.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

moved rest of entries before 2.1 to news2.en.xml

Checking in news2.en.xml;
/www/seamonkeyproject-org/src/news2.en.xml,v  <--  news2.en.xml
new revision: 1.3; previous revision: 1.2
done
Checking in news.en.xml;
/www/seamonkeyproject-org/src/news.en.xml,v  <--  news.en.xml
new revision: 1.135; previous revision: 1.134
done

(In reply to Justin Wood (:Callek) from comment #2)
> Yea, we got it, and it looks like the |build/full_build| is Modified
> locally, so we're getting 1 e-mail every 10 minutes until thats fixed

Do we have access to the machine so we can fix it, will it fix itself eventually (KaiRo mentioned some auto-clean that kicks in less often than normal updates), or will we have to ask Mozilla IT to send us a diff and undo the changes?

I guess the differences were made by IT for debugging purposes, but we should really get rid of that stuff now.

Comment 4

[Justin Wood (:Callek)]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #3)
> (In reply to Justin Wood (:Callek) from comment #2)
> > Yea, we got it, and it looks like the |build/full_build| is Modified
> > locally, so we're getting 1 e-mail every 10 minutes until thats fixed
> 
> Do we have access to the machine so we can fix it, will it fix itself
> eventually (KaiRo mentioned some auto-clean that kicks in less often than
> normal updates), 

Yea we don't have access to the machine atm ourselves, but you can find the cron entires that do run in Bug 722973.

> or will we have to ask Mozilla IT to send us a diff and
> undo the changes?
> 

We will have to either have IT undo the fixes, or us, or something (no idea the best process here, we should tackle that soon though to cut back on this e-mail spam)

> I guess the differences were made by IT for debugging purposes, but we
> should really get rid of that stuff now.

O that makes sense, and probably.