724339 - text selection on mobile devices must support right-to-left (rtl) languages

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, enhancement, P1)

Description

[Amir Aharoni]

Text selection doesn't exist on Fennec at this time at all. When it will be done, it must support right-to-left text selection. It works well in Safari on iPhone; it works more or less well on Opera, although the rendering of the selection background color is weird; it doesn't work in Webkit (on 2.3.4; it maybe be better in ICS).

Comment 1

[Tomer Cohen :tomer]

(In reply to Amir Aharoni from comment #0)
> it doesn't work in Webkit (on 2.3.4; it maybe be better in ICS).
It does work on WebKit (Browser/Android 2.3.7/Cyanogenmod), but it appears to not handle multiline selections correctly. 

As for Firefox, Firefox Beta on the same device does handle Right to left selection good enough.

Comment 2

[Amir Aharoni]

(In reply to Tomer Cohen :tomer from comment #1)
> (In reply to Amir Aharoni from comment #0)
> > it doesn't work in Webkit (on 2.3.4; it maybe be better in ICS).
> It does work on WebKit (Browser/Android 2.3.7/Cyanogenmod), but it appears
> to not handle multiline selections correctly. 

That's the point of this bug - if it doesn't handle multiline selection of right-to-left text correctly, then right-to-left text selection doesn't really work.

Comment 3

[:Margaret Leibovic]

Attachment: patch

(Based on top of my patch for bug 765072)

On an RTL page, the start handle is technically at the end of the selection, and vice versa. Our handle code doesn't need to know about that, but the code that sends mouse events to actually maintain the selection does.

For testing I used: http://people.mozilla.com/~mleibovic/test/lorem_ipsum_rtl.html

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/594e394c497e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/594e394c497e

Comment 6

[:Margaret Leibovic]

Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6