text selection on mobile devices must support right-to-left (rtl) languages

VERIFIED FIXED in Firefox 15

Status

()

Firefox for Android
Text Selection
P1
enhancement
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: Amir Aharoni, Assigned: Margaret)

Tracking

Trunk
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox15 verified, firefox16 verified, firefox17 fixed, fennec+)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Text selection doesn't exist on Fennec at this time at all. When it will be done, it must support right-to-left text selection. It works well in Safari on iPhone; it works more or less well on Opera, although the rendering of the selection background color is weird; it doesn't work in Webkit (on 2.3.4; it maybe be better in ICS).
(Reporter)

Updated

6 years ago
Depends on: 695173

Comment 1

6 years ago
(In reply to Amir Aharoni from comment #0)
> it doesn't work in Webkit (on 2.3.4; it maybe be better in ICS).
It does work on WebKit (Browser/Android 2.3.7/Cyanogenmod), but it appears to not handle multiline selections correctly. 

As for Firefox, Firefox Beta on the same device does handle Right to left selection good enough.
(Reporter)

Comment 2

6 years ago
(In reply to Tomer Cohen :tomer from comment #1)
> (In reply to Amir Aharoni from comment #0)
> > it doesn't work in Webkit (on 2.3.4; it maybe be better in ICS).
> It does work on WebKit (Browser/Android 2.3.7/Cyanogenmod), but it appears
> to not handle multiline selections correctly. 

That's the point of this bug - if it doesn't handle multiline selection of right-to-left text correctly, then right-to-left text selection doesn't really work.
Blocks: 695173
No longer depends on: 695173

Updated

6 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

6 years ago
tracking-fennec: --- → +
Priority: -- → P1
Version: Firefox 11 → Trunk
(Assignee)

Comment 3

5 years ago
Created attachment 635937 [details] [diff] [review]
patch

(Based on top of my patch for bug 765072)

On an RTL page, the start handle is technically at the end of the selection, and vice versa. Our handle code doesn't need to know about that, but the code that sends mouse events to actually maintain the selection does.

For testing I used: http://people.mozilla.com/~mleibovic/test/lorem_ipsum_rtl.html
Assignee: nobody → margaret.leibovic
Attachment #635937 - Flags: review?(mark.finkle)
Attachment #635937 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/594e394c497e
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/594e394c497e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

5 years ago
Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6
status-firefox15: --- → fixed
status-firefox16: --- → fixed
Component: General → Text Selection

Updated

5 years ago
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
status-firefox16: fixed → verified
status-firefox17: --- → affected

Updated

5 years ago
status-firefox17: affected → fixed
You need to log in before you can comment on or make changes to this bug.