724348 - about:home - vertical space is wasted with only 1 or 2 thumbnails shown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Peter Retzer (:pretzer)]

Attachment: Screenshot

When only one or two thumbnails are shown in the top sites area on about:home, a lot of vertical space is wasted because the whole space for four thumbnails is already reserved. See screenshot.

Comment 1

[Aaron Train [:aaronmt]]

/summon UX

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: (1/2) Remove unused variable from TopSitesGridView

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: (2/2) Only use the necessary vertical space for top sites in about:home

Comment 4

[Lucas Rocha (:lucasr)]

I had those patches in my queue before and forgot to send. I apologize if that caused duplicate effort on this bug.

Comment 5

[Lucas Rocha (:lucasr)]

Pushed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/e10c119aa662
http://hg.mozilla.org/integration/mozilla-inbound/rev/6564da6bf49e

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 596685 [details] [diff] [review]
(1/2) Remove unused variable from TopSitesGridView

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: Wasted space in about:home, ugly visuals
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 596686 [details] [diff] [review]
(2/2) Only use the necessary vertical space for top sites in about:home

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: Wasted space in about:home, ugly visuals
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/e10c119aa662
https://hg.mozilla.org/mozilla-central/rev/6564da6bf49e

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 596685 [details] [diff] [review]
(1/2) Remove unused variable from TopSitesGridView

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 10

[Camelia Urian]

Nightly 13.0a1 (2012-02-21)
Device: Samsung Nexus S - Android 2.3.6

Comment 11

[Matt Brubeck (:mbrubeck)]

Comment on attachment 596685 [details] [diff] [review]
(1/2) Remove unused variable from TopSitesGridView

Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions.  If this changes in the future, we will likely do a mass uplift of all native fennec changes.  For now, let's get these bugs off the channel triage radar.

[Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]

Comment 12

[Camelia Urian]

Nightly 13.0a1 (2012-02-28)
Device: Samsung Nexus S - Android 2.3.6

Verified fixed on Nightly.