724398 - specialize js_GCThingIsMarked to GRAY

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew McCreight [:mccr8]]

This is only every called with gc::GRAY (despite the default color argument being BLACK...), so if specializing this function and moving it to jsfriendapi reduces one spurious dependency of xpcpublic on jsgc.h.  It also slims down the interface a bit.  I also took the opportunity to clean up a comment that isn't true any more, now that static strings are true GCthings that can have their mark bits examined.

Comment 1

[Andrew McCreight [:mccr8]]

Should I keep the AssertValidColor even though it is always being called with GRAY?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

We have an AssertValidColor in Cell::isMarked as well, so it doesn't seem necessary.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: only lightly tested

Should be okay, but I'll push to try at some point.

Comment 4

[Andrew McCreight [:mccr8]]

Try run looked good.

https://hg.mozilla.org/integration/mozilla-inbound/rev/945dfb9d0c87

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/945dfb9d0c87