Last Comment Bug 724398 - specialize js_GCThingIsMarked to GRAY
: specialize js_GCThingIsMarked to GRAY
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla13
Assigned To: Andrew McCreight [:mccr8]
:
Mentors:
Depends on: 724495
Blocks: 692267
  Show dependency treegraph
 
Reported: 2012-02-05 10:47 PST by Andrew McCreight [:mccr8]
Modified: 2012-02-06 02:26 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
only lightly tested (4.51 KB, patch)
2012-02-05 12:54 PST, Andrew McCreight [:mccr8]
wmccloskey: review+
Details | Diff | Review

Description Andrew McCreight [:mccr8] 2012-02-05 10:47:32 PST
This is only every called with gc::GRAY (despite the default color argument being BLACK...), so if specializing this function and moving it to jsfriendapi reduces one spurious dependency of xpcpublic on jsgc.h.  It also slims down the interface a bit.  I also took the opportunity to clean up a comment that isn't true any more, now that static strings are true GCthings that can have their mark bits examined.
Comment 1 Andrew McCreight [:mccr8] 2012-02-05 10:50:27 PST
Should I keep the AssertValidColor even though it is always being called with GRAY?
Comment 2 Bill McCloskey (:billm) 2012-02-05 11:36:04 PST
We have an AssertValidColor in Cell::isMarked as well, so it doesn't seem necessary.
Comment 3 Andrew McCreight [:mccr8] 2012-02-05 12:54:35 PST
Created attachment 594587 [details] [diff] [review]
only lightly tested

Should be okay, but I'll push to try at some point.
Comment 4 Andrew McCreight [:mccr8] 2012-02-05 19:45:35 PST
Try run looked good.

https://hg.mozilla.org/integration/mozilla-inbound/rev/945dfb9d0c87
Comment 5 Marco Bonardo [::mak] 2012-02-06 00:55:03 PST
https://hg.mozilla.org/mozilla-central/rev/945dfb9d0c87

Note You need to log in before you can comment on or make changes to this bug.