Closed Bug 724398 Opened 12 years ago Closed 12 years ago

specialize js_GCThingIsMarked to GRAY

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

This is only every called with gc::GRAY (despite the default color argument being BLACK...), so if specializing this function and moving it to jsfriendapi reduces one spurious dependency of xpcpublic on jsgc.h.  It also slims down the interface a bit.  I also took the opportunity to clean up a comment that isn't true any more, now that static strings are true GCthings that can have their mark bits examined.
Assignee: general → continuation
Should I keep the AssertValidColor even though it is always being called with GRAY?
We have an AssertValidColor in Cell::isMarked as well, so it doesn't seem necessary.
Should be okay, but I'll push to try at some point.
Attachment #594587 - Flags: review?(wmccloskey)
Attachment #594587 - Flags: review?(wmccloskey) → review+
Try run looked good.

https://hg.mozilla.org/integration/mozilla-inbound/rev/945dfb9d0c87
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/945dfb9d0c87
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 724495
You need to log in before you can comment on or make changes to this bug.