The default bug view has changed. See this FAQ.

specialize js_GCThingIsMarked to GRAY

RESOLVED FIXED in mozilla13

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Depends on: 1 bug)

Trunk
mozilla13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This is only every called with gc::GRAY (despite the default color argument being BLACK...), so if specializing this function and moving it to jsfriendapi reduces one spurious dependency of xpcpublic on jsgc.h.  It also slims down the interface a bit.  I also took the opportunity to clean up a comment that isn't true any more, now that static strings are true GCthings that can have their mark bits examined.
(Assignee)

Updated

5 years ago
Assignee: general → continuation
(Assignee)

Comment 1

5 years ago
Should I keep the AssertValidColor even though it is always being called with GRAY?
We have an AssertValidColor in Cell::isMarked as well, so it doesn't seem necessary.
(Assignee)

Comment 3

5 years ago
Created attachment 594587 [details] [diff] [review]
only lightly tested

Should be okay, but I'll push to try at some point.
Attachment #594587 - Flags: review?(wmccloskey)
Attachment #594587 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 4

5 years ago
Try run looked good.

https://hg.mozilla.org/integration/mozilla-inbound/rev/945dfb9d0c87
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/945dfb9d0c87
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 724495
You need to log in before you can comment on or make changes to this bug.