Closed Bug 724446 Opened 8 years ago Closed 8 years ago

Cleanup leftover listener from browser_page_style_menu.js, in SeaMonkey

Categories

(SeaMonkey :: Testing Infrastructure, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.10

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

(Whiteboard: [fixed by bug 726521])

Attachments

(1 obsolete file)

Bug 724331 comment 1
{
Philip Chee      2012-02-04 20:19:21 PST

http://hg.mozilla.org/mozilla-central/rev/50a858927fad
Cleanup leftover listeners from browser/base/content browser-chrome tests
}

Bug 724331 fixed browser_bug427559.js.
browser_page_style_menu.js is the (only) other test that SeaMonkey has ported.
Sync' with current FF code, + Use a function name.
Attachment #594612 - Flags: review?(neil)
Summary: Cleanup leftover listener from browser_page_style_menu.js → Cleanup leftover listener from browser_page_style_menu.js, in SeaMonkey
Comment on attachment 594612 [details] [diff] [review]
(Av1) Cleanup leftover listener from browser_page_style_menu.js
[Included in bug 726521 patch Av1]

Can't we remove the event listener directly inside checkPageStyleMenu?
Comment on attachment 594612 [details] [diff] [review]
(Av1) Cleanup leftover listener from browser_page_style_menu.js
[Included in bug 726521 patch Av1]

(In reply to neil@parkwaycc.co.uk from comment #2)
> Can't we remove the event listener directly inside checkPageStyleMenu?

http://hg.mozilla.org/mozilla-central/filelog/default/browser/base/content/test/browser_page_style_menu.js
It was first added inside checkPageStyleMenu(), yes.
Then it was removed, though I assume this was a mistake.
Then is was re-added near addEventListener().

I think it's easier to match them that way and I would prefer to be in sync' with FF...
(It's easier to maintain and safer than to wonder why SM (can) does it differently.)
The former is shorter. The latter keeps the related event code closer together, so it might be easier to comprehend the flow at a glance.
Depends on: 726521
Attachment #594612 - Attachment description: (Av1) Cleanup leftover listener from browser_page_style_menu.js → (Av1) Cleanup leftover listener from browser_page_style_menu.js [Included in bug 726521 patch Av1]
Attachment #594612 - Attachment is obsolete: true
Attachment #594612 - Flags: review?(neil)
Fixed by bug 726521.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed by bug 726521]
You need to log in before you can comment on or make changes to this bug.