The default bug view has changed. See this FAQ.

nsTextFrameThebes assumes wrong bool size

RESOLVED FIXED in mozilla13

Status

()

Core
Layout: Misc Code
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: spectre, Assigned: spectre)

Tracking

Trunk
mozilla13
PowerPC
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 594619 [details] [diff] [review]
Use sizeof(bool) with memset()

From bug 720350, a two-line patch to fix bool size issues in nsTextFrameThebes. The other bug I was tracking in content/base/src/nsLineBreaker.cpp was already fixed.
(Assignee)

Updated

5 years ago
Attachment #594619 - Attachment is patch: true
Attachment #594619 - Flags: review?(bzbarsky)
(Assignee)

Comment 1

5 years ago
Er, three, even.
Comment on attachment 594619 [details] [diff] [review]
Use sizeof(bool) with memset()

r=me
Attachment #594619 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

5 years ago
Thank you kindly.
Keywords: checkin-needed

Updated

5 years ago
Assignee: nobody → spectre
Status: NEW → ASSIGNED
Whiteboard: [autoland-try]
Version: unspecified → Trunk

Updated

5 years ago
Whiteboard: [autoland-try] → [autoland-in-queue]

Comment 4

5 years ago
Autoland Patchset:
	Patches: 594619
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/811d13c9ada2
Try run started, revision 811d13c9ada2. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=811d13c9ada2
http://hg.mozilla.org/integration/mozilla-inbound/rev/b27b65ade4a6
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla13

Comment 6

5 years ago
Try run for 811d13c9ada2 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=811d13c9ada2
Results (out of 207 total builds):
    exception: 1
    success: 187
    warnings: 19
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-811d13c9ada2
 Timed out after 06 hours without completing.
https://hg.mozilla.org/mozilla-central/rev/b27b65ade4a6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [autoland-in-queue]
You need to log in before you can comment on or make changes to this bug.