724453 - nsTextFrameThebes assumes wrong bool size

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Cameron Kaiser [:spectre]]

Attachment: Use sizeof(bool) with memset()

From bug 720350, a two-line patch to fix bool size issues in nsTextFrameThebes. The other bug I was tracking in content/base/src/nsLineBreaker.cpp was already fixed.

Comment 1

[Cameron Kaiser [:spectre]]

Er, three, even.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 594619 [details] [diff] [review]
Use sizeof(bool) with memset()

r=me

Comment 3

[Cameron Kaiser [:spectre]]

Thank you kindly.

Comment 4

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 594619
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/811d13c9ada2
Try run started, revision 811d13c9ada2. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=811d13c9ada2

Comment 5

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b27b65ade4a6

Comment 6

[Mozilla RelEng Bot]

Try run for 811d13c9ada2 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=811d13c9ada2
Results (out of 207 total builds):
    exception: 1
    success: 187
    warnings: 19
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-811d13c9ada2
 Timed out after 06 hours without completing.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b27b65ade4a6