724457 - Shortcut key in menus looks like disabled

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

On the latest Nightly, shortcut key labels in menus are rendered as disabled, but I can use them.

I thought this is a XUL's regression, but I cannot see this bug on Daily of Tb.

I cannot reproduce this bug on Fx10.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, I was surprised at that it's intentional.

I have some thought.

* Why menus which are in menubar ignore the native look and feel.

* Even if it becomes the gray text, why we're using same color for both states. I meant that the gray text of enabled shortcut keys should be darker, or the disabled shortcut keys should be lighter. I.e., I think these colors should be different.

* Doesn't specifying physical color for the text break contrast with the background color if user changed the system settings?

Comment 2

[Dão Gottwald [:dao]]

Given bug 1521231, we should probably revert bug 610902 as well.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 724457 - Stop using graytext for shortcuts in menus. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31aea004045a
Stop using graytext for shortcuts in menus. r=Gijs

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/31aea004045a

Comment 6

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 67.0a1 (2019.01.31) on Win 7 x86.
I can confirm this issue is fixed, I verified using Firefox 68.0b6 Win 7 x86, Win 10 x64, Ubuntu 18.04 x64 and macOS 10.12.