724489 - PluginProvider.jsm should not assume that the list of plugins never changes

Status: RESOLVED DUPLICATE of bug 554780

(Toolkit :: Add-ons Manager, defect)

Description

[Wladimir Palant]

Attachment: Screenshot

I've noticed that the display of the Google Update plugin in the Add-on Manager is broken (see attached screenshot). Version number is missing, it is "disabled" but not grayed out (about:plugins on the other hand shows it as enabled), there is both an Enable and a Disable button but neither does anything, clicking "More" displays an empty page. The Error Console lists the following error:

> Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND)
> [nsILocalFile.lastModifiedTime]"  nsresult: "0x80520012
> (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame ::
> resource:///modules/PluginProvider.jsm :: <TOP_LEVEL> :: line 243

This is installDate getter trying to access modification time of the plugin file. Now I'm not sure which file it is trying to locate. I called nsIPluginHost.getPluginTags() manually - it gives me the correct location of npGoogleUpdate3.dll. The problem seems to be however that this file was updated a few days ago and moved from AppData/Local/Google/Update/1.3.21.79/ to AppData/Local/Google/Update/1.3.21.99/ when Firefox was already running. PluginProvider.jsm maintains a cached list of plugins but apparently doesn't update it when the list of plugins changes (the counterpart of bug 391625 for the new add-on manager). I guess that this cached list needs to be rebuilt on plugins-list-updated notification.

Comment 1

[Wladimir Palant]

Forgot to mention: this happened on Firefox 10. However, the current trunk code seems to be identical so that the issue should be reproducible there as well.

Comment 2

[Dave Townsend [:mossop]]

This is what the poorly described bug 554780 is about