724516 - Unregress handling of large standalone images that should span multiple pages when printing

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

The comment explicitly refers to printing. Obviously doesn't make sense in a "not print" block.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 594680 [details] [diff] [review]
patch

Review of attachment 594680 [details] [diff] [review]:
-----------------------------------------------------------------

er, nice catch!

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4bb2bcc8c95a

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4bb2bcc8c95a

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 594680 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): bug 713383
User impact if declined: low impact, regressing bug 528046
Testing completed (on m-c, etc.): manual on m-c
Risk to taking this patch (and alternatives if risky): no risk, alternative is to accept regressing bug 528046

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 594680 [details] [diff] [review]
patch

[Triage Comment]
Approving for Aurora 12 and Beta 11 along with bug 713383 in support of printing images. Since this is landing fairly late, adding the qawanted keyword to get some extra testing around printing this cycle.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/7a1b738dd4e7
http://hg.mozilla.org/releases/mozilla-beta/rev/3034f4ec14e9

Comment 7

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0) Gecko/20100101 Firefox/11.0

Tried with Firefox 11 beta 4 - printing the following image
https://bug528046.bugzilla.mozilla.org/attachment.cgi?id=411803
Prints on separate pages, as expected.(with/without zoom)

Comment 8

[Paul Silaghi, QA [:pauly]]

Should the image be printed on separate pages even without zoom?
https://bug528046.bugzilla.mozilla.org/attachment.cgi?id=411803

Comment 9

[Dão Gottwald [:dao]]

(In reply to Paul Silaghi [QA] from comment #8)
> Should the image be printed on separate pages even without zoom?
> https://bug528046.bugzilla.mozilla.org/attachment.cgi?id=411803

yes

Comment 10

[Paul Silaghi, QA [:pauly]]

Verified fixed on Firefox 12b2:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0