724570 - Vertical alignment is wrong for <select> options in <optgroup>

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Martijn Wargers (dead)]

Attachment: Screenshot of bug

See url testcase.
Tap on the multi-select to open up the select helper popup.

Expected result:
- Checkboxes vertically aligned to each other

Actual result:
- Checkboxes not vertically aligned to each other

This might very well be a regression from bug 715925.

So I guess this url also shows the bug then: https://bug685197.bugzilla.mozilla.org/attachment.cgi?id=559176

Comment 1

[Doug Turner (:dougt)]

wesj, is this a known regression as comment #0 suggestion?

Comment 2

[Wesley Johnston (:wesj)]

Yep. Fix shouldn't be to hard.

Comment 4

[Matt Brubeck (:mbrubeck)]

This bug is not currently visible on trunk because the code to add padding for <optgroup> children stopped working.  Bug 761216 removes this code completely.  I'll use this bug to restore the code while fixing the alignment problems.

I think the cause of the original bug here is CheckedTextView messing with its own padding, so setPadding has some unexpected side effects.  The code for this varies in different versions of Android, but see for example:
http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/android/4.0.4_r1.2/android/widget/CheckedTextView.java?av=f#148

Comment 5

[Matt Brubeck (:mbrubeck)]

Attachment: WIP hack

This works but is quite ugly.

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.