Last Comment Bug 724584 - ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr' in imgRequest::Init
: ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr' in imgReque...
Product: Core
Classification: Components
Component: ImageLib (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla13
Assigned To: Joe Drew (not getting mail)
: Milan Sreckovic [:milan]
Depends on:
  Show dependency treegraph
Reported: 2012-02-06 10:01 PST by Marco Bonardo [::mak]
Modified: 2012-02-14 02:32 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

use nsIRequest (1001 bytes, patch)
2012-02-06 10:21 PST, Joe Drew (not getting mail)
jmuizelaar: review+
Details | Diff | Splinter Review

Description User image Marco Bonardo [::mak] 2012-02-06 10:01:59 PST
xul.dll!nsCOMPtr<nsIRequest>::Assert_NoQueryNeeded()  Line 532 + 0x2a bytes	C++
xul.dll!nsCOMPtr<nsIRequest>::operator=(nsIRequest * rhs)  Line 653	C++
xul.dll!imgRequest::Init(nsIURI * aURI, nsIURI * aCurrentURI, nsIRequest * aRequest, nsIChannel * aChannel, imgCacheEntry * aCacheEntry, void * aLoadId, nsIPrincipal * aLoadingPrincipal, int aCORSMode)  Line 162	C++
 	xul.dll!imgCacheValidator::OnStartRequest(nsIRequest * aRequest, nsISupports * ctxt)  Line 2211	C++

The JS Stack ends with PageThumbsProtocol.js::Channel_startRequest

Joe thinks it's due to the third argument here that should be aRequest and not the channel.
Comment 1 User image Joe Drew (not getting mail) 2012-02-06 10:21:26 PST
Created attachment 594745 [details] [diff] [review]
use nsIRequest

I'm pretty sure that just using inheritance breaks XPCOM rules; luckily, we have this existing nsIRequest lying around.
Comment 2 User image Daniel Holbert [:dholbert] (vacation, returning 2/27) 2012-02-13 14:37:10 PST
Comment 3 User image Marco Bonardo [::mak] 2012-02-14 02:32:23 PST

Note You need to log in before you can comment on or make changes to this bug.