Closed
Bug 724584
Opened 13 years ago
Closed 13 years ago
ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr' in imgRequest::Init
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: mak, Assigned: joe)
Details
Attachments
(1 file)
|
1001 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
xul.dll!nsCOMPtr<nsIRequest>::Assert_NoQueryNeeded() Line 532 + 0x2a bytes C++
xul.dll!nsCOMPtr<nsIRequest>::operator=(nsIRequest * rhs) Line 653 C++
xul.dll!imgRequest::Init(nsIURI * aURI, nsIURI * aCurrentURI, nsIRequest * aRequest, nsIChannel * aChannel, imgCacheEntry * aCacheEntry, void * aLoadId, nsIPrincipal * aLoadingPrincipal, int aCORSMode) Line 162 C++
xul.dll!imgCacheValidator::OnStartRequest(nsIRequest * aRequest, nsISupports * ctxt) Line 2211 C++
The JS Stack ends with PageThumbsProtocol.js::Channel_startRequest
Joe thinks it's due to the third argument here that should be aRequest and not the channel.
http://mxr.mozilla.org/mozilla-central/source/image/src/imgLoader.cpp#2207
|
Assignee | |
Comment 1•13 years ago
|
||
I'm pretty sure that just using inheritance breaks XPCOM rules; luckily, we have this existing nsIRequest lying around.
Attachment #594745 -
Flags: review?(jmuizelaar)
|
||
Updated•13 years ago
|
Attachment #594745 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 2•13 years ago
|
||
|
Reporter | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•