ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr' in imgRequest::Init

RESOLVED FIXED in mozilla13

Status

()

Core
ImageLib
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mak, Assigned: Joe Drew (not getting mail))

Tracking

Trunk
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
xul.dll!nsCOMPtr<nsIRequest>::Assert_NoQueryNeeded()  Line 532 + 0x2a bytes	C++
xul.dll!nsCOMPtr<nsIRequest>::operator=(nsIRequest * rhs)  Line 653	C++
xul.dll!imgRequest::Init(nsIURI * aURI, nsIURI * aCurrentURI, nsIRequest * aRequest, nsIChannel * aChannel, imgCacheEntry * aCacheEntry, void * aLoadId, nsIPrincipal * aLoadingPrincipal, int aCORSMode)  Line 162	C++
 	xul.dll!imgCacheValidator::OnStartRequest(nsIRequest * aRequest, nsISupports * ctxt)  Line 2211	C++

The JS Stack ends with PageThumbsProtocol.js::Channel_startRequest

Joe thinks it's due to the third argument here that should be aRequest and not the channel.
http://mxr.mozilla.org/mozilla-central/source/image/src/imgLoader.cpp#2207
(Assignee)

Comment 1

6 years ago
Created attachment 594745 [details] [diff] [review]
use nsIRequest

I'm pretty sure that just using inheritance breaks XPCOM rules; luckily, we have this existing nsIRequest lying around.
Attachment #594745 - Flags: review?(jmuizelaar)
Attachment #594745 - Flags: review?(jmuizelaar) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c7130f50c21
Keywords: checkin-needed
Target Milestone: --- → mozilla13
Version: 13 Branch → Trunk
(Reporter)

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/1c7130f50c21
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.