Closed Bug 724615 Opened 10 years ago Closed 10 years ago

Fix TARGET_CPU usage on ARM

Categories

(Core :: XPCOM, defect)

ARM
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: armin76, Assigned: armin76)

Details

Attachments

(1 file)

Attached patch arm.patchSplinter Review
xpcom/glue/objs.mk uses a generic 'arm' to check whether to build an ARM-specific object file or not.

The checks are done using "ifeq (arm,$(TARGET_CPU))", this would only work on Linux on those cases where the compiler has a CTARGET like arm-none-linux-gnueabi. Some other distros(gentoo, f.ex) use specific triplets for the different ARM subarchitectures, f.ex armv7a-unknown-linux-gnueabi, therefore making this check useless.

With the patch i'm attaching i'm doing the same approach as xpcom/reflect/xptcall/src/md/unix/Makefile.in, although in that case it uses OS_TEST and not TARGET_CPU, but the problem is the same as OS_TEST on ARM is ${target_cpu}.
Attachment #594755 - Flags: review?(benjamin)
Attachment #594755 - Flags: review?(benjamin) → review+
Assignee: nobody → armin76
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d05120728598
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.