Last Comment Bug 724615 - Fix TARGET_CPU usage on ARM
: Fix TARGET_CPU usage on ARM
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: unspecified
: ARM Linux
-- normal (vote)
: mozilla13
Assigned To: Raúl Porcel
: Nathan Froyd [:froydnj]
Depends on:
  Show dependency treegraph
Reported: 2012-02-06 11:03 PST by Raúl Porcel
Modified: 2012-02-07 12:13 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

arm.patch (749 bytes, patch)
2012-02-06 11:03 PST, Raúl Porcel
benjamin: review+
Details | Diff | Splinter Review

Description User image Raúl Porcel 2012-02-06 11:03:16 PST
Created attachment 594755 [details] [diff] [review]

xpcom/glue/ uses a generic 'arm' to check whether to build an ARM-specific object file or not.

The checks are done using "ifeq (arm,$(TARGET_CPU))", this would only work on Linux on those cases where the compiler has a CTARGET like arm-none-linux-gnueabi. Some other distros(gentoo, f.ex) use specific triplets for the different ARM subarchitectures, f.ex armv7a-unknown-linux-gnueabi, therefore making this check useless.

With the patch i'm attaching i'm doing the same approach as xpcom/reflect/xptcall/src/md/unix/, although in that case it uses OS_TEST and not TARGET_CPU, but the problem is the same as OS_TEST on ARM is ${target_cpu}.
Comment 2 User image Ed Morley [:emorley] 2012-02-07 12:13:38 PST

Note You need to log in before you can comment on or make changes to this bug.